Goto definition does not work for many symbols in `#lang rhombus` due to DrRacket/Rhombus

[sidkshatriya]

Shplait is a great test project for testing LSP functionality in Rhombus ( https://github.com/mflatt/shplait )

Lets take a simple-ish file private/boxval.rhm in the shplait source code

#lang rhombus/static/and_meta
import:
  meta:
    "type.rhm" as t
  "type_statinfo.rhm" as t_s
  "value.rhm".value
  "wrap.rhm" open
  "lazy.rhm" open

// etc OMITTED
// etc OMITTED

expr.macro 'make_box':
  ~op_stx self
  let tv = t.gen_tvar(self)
  t_s.wrap_type('box_wrap'.relocate(self),
                t.Poly(self, tv, t.Arrow(self, [tv], t.BoxOf(self, tv))))

In the expr.macro 'make_box'

• Goto definition on t_s does not work
• Goto definition on t (at t.gen_tvar) does not work
• Goto definition on wrap_type does not work
• Goto definition on gen_tvar does not work

EDIT: The information for these symbols is missing in DrRacket also (see #226 (comment) ) . The fix will need to be made upstream either in DrRacket or Rhombus itself ...

[sidkshatriya]

cc: @dannypsnl @6cdh

LSP is already helpful on Rhombus. It would be great if the goto definition could be made more robust for it too.

Please note that Rhombus may need to be installed from master

git clone https://github.com/racket/rhombus
cd rhombus
# --adjacent-deps is available in Racket 9.3
raco pkg install --adjacent-deps -t dir rhombus-main

P.S. Thank you for all your work on racket-langserver ! The server has improved a great deal in quality !!

[6cdh]

I did some experiment.

This cannot be done in LSP server side easily. racket-langserver uses DrRacket API for go to definition. But the info of t, t_s and other symbols are missing in DrRacket. For example, open boxval.rhm in DrRacket, it does not show binding arrows of t and t_s. It needs to be fixed in upstream.

[sidkshatriya]

@mflatt
We're trying to fix the lack of binding arrows in the shplait example above in DrRacket (and consequently racket-langserver). Would greatly appreciate if you could have a look and possibly hint us how to solve the issue ! Thanks so much :-) !