Repository navigation
Select enclosing TP6 procedures by explicit bounded TPU9 entry - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fresh Pyro numeric-display reconstruction emits its two nested helpers before its enclosing routine (code offsets 0,50,131). The existing earliest-entry-only API cannot select the actual target without callers writing their own decoder.
Add optional keyword-only code_offset to primary_span/primary_routine. It must name an exact declared code-section-relative entry; no arbitrary byte offsets, byte-pattern search, fallback to other entries, or reads beyond the owning entry/block. Existing default behavior and error messages remain unchanged.
Twelve new regression cases failed before implementation and all pass after it, covering later-entry selection, invalid types/offsets, undeclared literal prologues, adjacent returns, cumulative block geometry, aliases and failed selected entries. Local focused suite: 43 passed (31 existing + 12 new). No licensed binaries included.
Consumer validation: dostools PR #11 has freshly compiled the enclosing 156-byte Pyro routine with TP6 inside PyPC-MCP, with four real wrong-source controls; parent integration will use this explicit selector instead of the temporary probe decoder.