Repository navigation
Recognize no-local TP6 epilogues and preserve hidden static-link evidence - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduced defect
A real Turbo Pascal 6 nested procedure with no local allocation ends in
pop bp; ret 6, withoutmov sp,bp.analyse_framerecognized only the longer epilogue and lost the return discipline, popped-byte count, and unread static-link slot.Fix
Recognize the short epilogue only when no nonzero local allocation was observed. Allocated frames still require the observed SP reset. Preserve the BP-frame and POP BP checks. Correct the explanatory
RET 4comment: four bytes are two words, not one; caller-owned string-result buffers can account for reads beyond the popped area.Verification
New regression file: 6 failures / 5 passes before the fix; all 11 pass after. Full local Python 3.13 suite: 197 passed, 36 skipped. The same suite passed on GitHub while publishing the code. Fresh PR CI will check this final head, which contains no temporary review workflows.
Controls cover near/far returns, zero/nonzero local allocation, the unread nested static link, missing BP setup, wrong POP, and absent POP. Only source and generic instruction-byte tests are included.