Repository navigation
Give RPC-controlled runs exclusive keyboard ownership - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Telnet and VNC could enqueue guest keys directly on producer threads, bypassing revision guards and changing input during a controlled capture. RPC-enabled runs now give both frontends no keyboard target. RPC keyboard input stays available; explicit --no-rpc disables the debugger listener and retains normal frontend keys. No concurrent local-input/guarded-control mode is introduced.
Validation: 50 affected tests pass on Windows CPython and PyPy, including real listener startup with and without RPC, production callbacks for all mapped VNC keys, complete configured-machine/control immutability, unchanged guarded capture, retained manual keys and RPC enqueue. Restoring the old frontend binding makes the complete-state control fail, then restored source passes. Public CI on the final rebased head is required before integration.