Repository navigation
Reject ambiguous text address selectors in shared RPC - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requests supplying both page and display_address previously silently selected page. Both video.text and state.observe now reject the ambiguous request with -32602 before reading text, including equal/null values; individual selectors retain their behavior.
Validation: 11 observation tests pass CPython and bare PyPy; 16 focused pytest cases and51 subtests pass. Complete configured-machine/control equality covers rejection and individual-selector positives, production JSON-lines checks verify actual error codes, and an omitted-guard mutant fails the named refusal control before restored source passes. Public final-head CI and original-game common protocol validation are pending.