Repository navigation
Capture coherent stopped observations without device reads - #69
Merged
Merged
Conversation
Seven new positive/negative observation tests pass on CPython/PyPy; full Windows regression 1489 passed, 23 skipped, 320 subtests. Persistent-TCP PyPy test-machine benchmark gives identical captures at 92.26ms for six requests and 15.37ms for one over 100 alternating pairs. No gameplay throughput claim. Independent review and final-head CI remain pending.
Independent review identified the BC000-BFFFF refusal. Eight observation tests pass on Windows CPython/PyPy, including backing-wrap boundaries and higher-priority ROM overlays. Tightened the captured-state assertion name to its actual scope. Follow-up review pending.
28 focused Windows CPython tests plus 35 subtests and 22 PyPy unittest cases pass. Steps distinguish accepted entry registers from completed pause/watchpoint/instruction states; segmented Words reject invalid components and wrap at 20 bits. Structured RPCError preserves RuntimeError text/compatibility and no-replay connection closure. Final-head CI and independent review pending.
29 focused CGA/VGA/observation tests pass on Windows CPython/PyPy. Nonzero text-page pixels equal page0; FFFF CRTC start wraps and coherent capture reads end/start cells in order. Corrected preceding handoff test count from 28 to actual 27.
Follow-up review's evidence gap is closed by comparing production capture_machine CPU/device/RAM/RNG/disk-transfer products and debugger control before and after coherent capture. 15 focused Windows CPython tests plus25 subtests pass. Corrected the earlier CGA test count to28.
Shared stdlib motherboard fixture replaces duplicate pytest-coupled factories. All9 observation unittest cases pass on Windows CPython and bare PyPy; 33 related pytest tests plus25 subtests pass with owned scratch and valid DEVNULL child input. Full machine/state/RNG/disk evidence remains exact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coherent paused observations collect registers, bounded RAM/ROM/text memory windows and optional text video in one revision-guarded RPC. Unsafe MMIO and VGA planar reads are refused without invoking consuming device reads.
Validation: seven new positive/negative tests pass on Windows CPython and PyPy; full Windows suite: 1489 passed, 23 skipped, 320 subtests. A retained persistent-TCP PyPy test-machine benchmark requires identical responses and measures 92.26ms median for six calls versus 15.37ms for one. This measures observation overhead, not game execution. Independent review, common live-game contract and final-head public CI remain pending.