Repository navigation
chore(postcard-derive): allow syn v3 - #302
Open
AudaciousAxiom wants to merge 2 commits into
Open
AudaciousAxiom wants to merge 2 commits into
AudaciousAxiom wants to merge 2 commits into
Conversation
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the recent release of
synv3, this allows using the new version as a dependency ofpostcard-deriveandpostcard-derive-ng, with the aim of reducing dependency duplication in dependents.synv3 advertises an MSRV of 1.71 and it's unclear to me whatpostcard's MSRV is intended to be, but because this allows bothsynv2 and v3, this shouldn't affect the MSRV (as a compatible version ofsynv2 could still be selected by dependents if needed).synv3 of course contains breaking changes: I've been through the changelog but didn't find anything relevant (but there are quite a few of them so I could have missed some). I've runcargo testbut didn't do any other kind of testing.