Repository navigation
Implement MaxSize and Schema for enum_map::EnumMap - #300
Merged
Merged
Conversation
✅ Deploy Preview for cute-starship-2d9c9b canceled.
|
Contributor
Author
|
May as well close this, I released enum-map 3.0.0, and currently it's not exactly possible to implement those traits for the newest version due to changes I did to make the interface nicer, due to missing language features. |
Contributor
Author
|
Or, actually, no, it is possible. |
Contributor
Author
|
Updated the pull request to be for enum-map 3.0.0. |
max-heller
requested changes
Jul 20, 2026
sugar700
force-pushed
the
enum-map-v2_0
branch
6 times, most recently
from
July 20, 2026 17:51
155eb9b to
c898109
Compare
max-heller
approved these changes
Jul 20, 2026
Collaborator
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was requested in
enum_map, with the pull request at https://codeberg.org/sugar700/enum-map/pulls/170, however I decided against that due to experimental status ofMaxSizetrait.I also implemented
Schema, mostly because I could do so.