Repository navigation
Update audio dependencies - #129
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade the audio decoding and resampling dependency stack:
audioadapterto 4.0.0audioadapter-buffersto 4.0.0rubatoto 3.0.0symphoniato 0.6.0Migrate decoding, probing, packet handling, and audio-buffer conversion to the new Symphonia APIs.
Behavior changes
No intentional user-facing behavior changes. Audio decoding, downmixing, resampling, and streaming transcription behavior remain unchanged.
Edge cases
Verification
cargo fmt --all -- --checkcargo clippy --all-targets --features bin-scribble-cli,bin-model-downloader,bin-scribble-server -- -D warningscargo check --features bin-scribble-cli,bin-model-downloader,bin-scribble-server./scripts/test-all.shAll 55 tests and doc tests pass.
Follow-up
Rubato 3 depends on audioadapter 3 internally, so both audioadapter 3 and 4 are currently present in the dependency graph. A future Rubato upgrade can remove this duplication once it supports audioadapter 4.