Conversation
…ed-pr-7609-7637-7640
…7640' into maximiliank/combined-pr-7609-7637-7640
Contributor
Author
|
run-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add controlled Newton MPM tuning examples and a discoverable solver/material tuning guide. Merge current
developinto the feature branch and keep the final diff focused on tuning demos, their documentation, and the proxy-feedback configuration needed by the G1 comparison.Organization and scope
scripts/demos/mpm/tuning/: a ten-preset material runner, nearly rigid MPM versus MJWarp primitives, G1 particle coupling, and surface reconstruction.docs/source/concepts/solver-tuning/tune_mpm.rst, alongside the existing VBD, MJWarp, PhysX, and Kamino guides. Link it from the MPM introduction, demos page, and local README.CouplerProxyMappingCfg. Explain why zero fixed relaxation from a fresh state means one-way coupling and whymode="lagged"does not.Media and remaining draft work
The guide has labeled, versioned publication slots rather than broken public video links. A local presentation archive contains 23 MP4s plus posters, capture parameters, and checksums. This archive is not the publication selection: publish only reviewed clips referenced by the documentation. Franka Pour and UR10 Particle Push clips belong with their task/policy documentation, not this tuning batch; standalone benchmark footage is also outside this PR's tuning scope.
The established documentation media host is
https://download.isaacsim.omniverse.nvidia.com/isaaclab/images/, including video files. Publication is coordinated through the documentation-media owners, separately from normal simulation-asset synchronization. No files have been uploaded or made public by this PR.The archived MP4s passed saved-checksum, codec/frame-count, and full-decode checks. Those checks verify file integrity, not physical correctness. Recordings made with post-step collider projection need review or re-recording before they illustrate the corrected, projection-disabled demos.
Historical G1 recordings use 25 mm voxels and 20 cm strips; the cleaned-up demo defaults to 40 mm voxels and 16 cm strips. The selected older one-way and full-body two-way clips have different proxy selections and are explicitly not advertised as a matched single-variable comparison. Older rigid-MPM footage is illustrative, not a current accuracy validation.
Validation
uv run --frozen python -m pytest source/isaaclab/test/app/test_standalone_scripts.py source/isaaclab_contrib/test/coupling/test_coupler.py -q -k 'not launch'— 101 passed, 398 opt-in runtime cases skipped, 9 deselected.--visualizer noneat coarse resolution; G1 with Newton GL and Kit at the default resolution; surface reconstruction with Newton GL including a render update.uv run --frozen isaaclab -f— passed.uv run --frozen python tools/changelog/cli.py check develop— passed.make -C docs current-docs, the follow-upuv run --frozen --isolated --extra test --extra dev -- sphinx-build -W --keep-going -j auto . _build/current(fromdocs/) passed without warnings. Both extras are selected because this branch keeps Sphinx indev.Type of change
Release backport
developScreenshots
Video publication slots are included in the guide. Encoded media are intentionally not committed.
Checklist
uv run isaaclab -fCONTRIBUTORS.md