Skip to content

Preserve None for reset event terms - #7894

Draft
kgu42 wants to merge 2 commits into
isaac-sim:developfrom
kgu42:kgu42/fix-event-reset-none-selector
Draft

kgu42 wants to merge 2 commits into
isaac-sim:developfrom
kgu42:kgu42/fix-event-reset-none-selector

Conversation

@kgu42

@kgu42 kgu42 commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixes #7791.

EventManager.apply(mode="reset", env_ids=None) converted None to
slice(None) for internal reset bookkeeping. Unfiltered event terms then
received that slice instead of None, causing built-in terms that expect
torch.Tensor | None to fail.

This change keeps the caller-provided env_ids unchanged and uses a separate
resolved_env_ids selector for internal bookkeeping.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Release backport

  • Backport this pull request to the active release branch after it merges into develop

Screenshots

N/A

Testing

  • ./isaaclab.sh -p -m pytest source/isaaclab/test/managers/test_event_manager_unit.py -q
  • ./isaaclab.sh -f

Checklist

Docker and GPU tests run on demand. Push the commits you want tested, then
comment run-ci on the pull request.

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a changelog fragment under source/<pkg>/changelog.d/ for every touched package (do not edit CHANGELOG.rst or bump extension.toml — CI handles that)
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Keep the all-environment slice local to reset bookkeeping.

Unfiltered event callbacks now receive None.

Add kitless coverage for unfiltered and trigger-filtered reset terms.
@github-actions github-actions Bot added bug Something isn't working isaac-lab Related to Isaac Lab team labels Sep 19, 2026
@kgu42

kgu42 commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator Author

run-ci

@isaaclab-bot isaaclab-bot Bot added ci:run-docker Trigger the on-demand Docker and GPU CI workflow and removed ci:run-docker Trigger the on-demand Docker and GPU CI workflow labels Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] EventManager.apply(reset, env_ids=None) passes slice(None) to event terms

1 participant