Conversation
Keep the all-environment slice local to reset bookkeeping. Unfiltered event callbacks now receive None. Add kitless coverage for unfiltered and trigger-filtered reset terms.
Collaborator
Author
|
run-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7791.
EventManager.apply(mode="reset", env_ids=None)convertedNonetoslice(None)for internal reset bookkeeping. Unfiltered event terms thenreceived that slice instead of
None, causing built-in terms that expecttorch.Tensor | Noneto fail.This change keeps the caller-provided
env_idsunchanged and uses a separateresolved_env_idsselector for internal bookkeeping.Type of change
Release backport
developScreenshots
N/A
Testing
./isaaclab.sh -p -m pytest source/isaaclab/test/managers/test_event_manager_unit.py -q./isaaclab.sh -fChecklist
Docker and GPU tests run on demand. Push the commits you want tested, then
comment
run-cion the pull request.pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.toml— CI handles that)CONTRIBUTORS.mdor my name already exists there