Conversation
|
run-ci |
There was a problem hiding this comment.
Isaac Lab Review Bot
Reviewed the coordinated OV compatibility-set upgrade to OVRTX 0.5.0.377615, OVStage 0.2.0.377349, OvPhysX 0.6.3, and omniverseclient 2.74.0. The dependency pins, compatibility metadata, installation guidance, CPU-resident selectors, and renderer golden references are updated consistently; no actionable candidate findings were supplied.
- Design and architecture: The existing version-based compatibility architecture remains intact: runtime behavior is selected from installed package metadata at established OVStage 0.2, OvPhysX 0.6, and OVRTX 0.5 boundaries. The root version table, optional extras, and isaaclab_ov package dependency reflect the coordinated compatibility set.
- API: The dependency upgrade is explicitly marked as breaking and includes migration guidance. The OV extras, package-level OVStage requirement, OVRTX installation error, and OvPhysX documentation use the updated versions consistently, without removing or renaming public symbols.
- Implementation: The pin-consistency test was updated, CPU-backed deformable material selectors are explicitly allocated on CPU, and compatibility-module documentation matches the existing fallback paths. The regenerated Franka renderer baselines carry some review risk because binary image differences are represented only by new LFS hashes, particularly given the noted unresolved color-parity investigation, but the patch provides no concrete failure demonstrating that these baselines are incorrect.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
|
|
run-ci |
1 similar comment
|
run-ci |
Description
Upgrades the optional OV dependency set to:
ovrtx==0.5.0.377615ovstage==0.2.0.377349ovphysx==0.6.3omniverseclient==2.74.0All packages resolve from public PyPI. These versions form one compatibility set and must be upgraded together.
The change also updates the OvPhysX installation documentation, compatibility metadata, deformable rendering references, and CPU-resident selectors required by CPU-backed OvPhysX properties.
Migration
Use
--extra ovrtxor--extra ovphysxwhen only one runtime is needed. CPU-backed OvPhysX property writes require CPU-resident values and selectors.Known test state:
Neither case is masked or rebaselined by this PR.
Type of change
Release backport
developChecklist
pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.toml— CI handles that)CONTRIBUTORS.mdor my name already exists there