feat: Implement BFD for BGPPeers#438
Open
sven-rosenzweig wants to merge 1 commit into
Open
Conversation
sven-rosenzweig
force-pushed
the
feat/bfd_for_bgppeer
branch
2 times, most recently
from
July 10, 2026 10:38
3400add to
37e3c78
Compare
| SrcIf string `json:"srcIf,omitempty"` | ||
|
|
||
| // BFD enablement | ||
| PeerControl string `json:"ctrl"` |
Contributor
There was a problem hiding this comment.
I don't see this field at all in the YANG model. Should we delete it?
Contributor
Author
There was a problem hiding this comment.
I somehow have in my had, this was needed to activate the BFD feature.
This should be the field:
https://github.com/YangModels/yang/blob/559418adbd5f05860c36b1d2ffa590ef8ee0309e/vendor/cisco/nx/10.6-2/Cisco-NX-OS-device.yang#L48686-L48690
sven-rosenzweig
force-pushed
the
feat/bfd_for_bgppeer
branch
from
July 22, 2026 12:08
37e3c78 to
df40292
Compare
sven-rosenzweig
marked this pull request as ready for review
July 22, 2026 12:08
Signed-off-by: Sven Rosenzweig <sven.rosenzweig@sap.com>
sven-rosenzweig
force-pushed
the
feat/bfd_for_bgppeer
branch
from
July 22, 2026 12:10
df40292 to
5c9c1e1
Compare
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.