Skip to content

[3/N] Synchronize test files with upstream generalization changes - #5435

Open
pbielak wants to merge 9 commits into
mainfrom
use-upstream-files-3
Open

pbielak wants to merge 9 commits into
mainfrom
use-upstream-files-3

Conversation

@pbielak

@pbielak pbielak commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

@pbielak
pbielak requested a review from BBBela September 18, 2026 08:25
@pbielak pbielak added disable_e2e Disable all e2e test jobs for the PR disable_distributed Disable distributed UT test jobs for the PR disable_auto Disable auto label workflow for PR labels Sep 18, 2026
@pbielak
pbielak force-pushed the use-upstream-files-3 branch from d7c6e4b to 84c0648 Compare September 18, 2026 08:34

@BBBela BBBela left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense for me to include those new test files in torch-xpu-ops CI, especially as they are now generalized in upstream and launched in upstream XPU CI.
It looks like necessary step to prevent all the torch-xpu-ops PRs from introducing any regression.

Although they were not ported for XPU so far due to reasons I don't know, so it would be best to have an official confirmation from PRC team that we can proceed with enabling testing all the device-related test files from upstream that are already generic, but have not been tested in torch-xpu-ops CI so far.

To sum up - for me the change looks good, but I will wait with approval until PRC team confirms we can introduce all those new tests into torch-xpu-ops CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disable_auto Disable auto label workflow for PR disable_distributed Disable distributed UT test jobs for the PR disable_e2e Disable all e2e test jobs for the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants