Skip to content

fix(keepers): use consistent routing for OPinit - #166

Merged
traviolus merged 1 commit into
mainfrom
fix/opinit-route
May 15, 2026
Merged

traviolus merged 1 commit into
mainfrom
fix/opinit-route

Conversation

@traviolus

@traviolus traviolus commented May 15, 2026 •

Copy link
Copy Markdown
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Corrected the IBC route registration configuration to properly identify the OPChild module, ensuring routes are registered with the correct identifier.

@traviolus
traviolus requested a review from a team as a code owner May 15, 2026 09:04
@coderabbitai

coderabbitai Bot commented May 15, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c791cef5-441e-44cc-baf8-ad83243d341c

📥 Commits

Reviewing files that changed from the base of the PR and between e8ee4ba and d3ed6d7.

📒 Files selected for processing (1)
  • app/keepers/keepers.go

Walkthrough

The IBC router configuration in the keepers setup file was updated to register the OPChild route using opchildtypes.PortID as the route key instead of opchildtypes.ModuleName, while keeping the routed module and all other router configuration unchanged.

Changes

IBC Router Configuration

Layer / File(s) Summary
OPChild route key identifier
app/keepers/keepers.go
The IBC router's OPChild route registration now uses opchildtypes.PortID instead of opchildtypes.ModuleName as the route key.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A single line shifted with care,
PortID in place, a fix crystal-clear,
The router now routes with the right ID,
IBC flows smooth, as they should be! 🌟

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions 'OPinit' but the actual change involves updating the OPChild router configuration to use PortID instead of ModuleName. Update the title to accurately reflect the change, such as: 'fix(keepers): use PortID for OPChild router registration' or 'fix(keepers): fix OPChild route registration'
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/opinit-route

Comment @coderabbitai help to get the list of available commands and usage tips.

@beer-1 beer-1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 42.54%. Comparing base (6c1c8e5) to head (d3ed6d7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/keepers/keepers.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   42.54%   42.54%           
=======================================
  Files          49       49           
  Lines        3154     3154           
=======================================
  Hits         1342     1342           
  Misses       1675     1675           
  Partials      137      137           
Files with missing lines Coverage Δ
app/keepers/keepers.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@traviolus
traviolus merged commit d47bbb0 into main May 15, 2026
10 of 11 checks passed
@traviolus
traviolus deleted the fix/opinit-route branch May 15, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants