Repository navigation
feat: bump ibc-go v10, sdk v0.53, cometbft v0.38.21 - #161
Merged
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpgrade IBC to v10 and CosmWasm wasmvm to v3, thread ChangesIBC Hooks & Packet Flows
IBC Keeper & Middleware Rewiring
App Initialization & Modules
Wasm Keeper Call Sites & Module Cleanups
Dependency & Tooling
Sequence Diagram(s)sequenceDiagram
participant Relayer as Relayer
participant Hooks as WasmHooks
participant Middleware as IBCMiddleware
participant App as Application
participant Wasm as WasmContract
Relayer->>Hooks: OnRecvPacket(channelVersion, packet)
Hooks->>Middleware: OnRecvPacket(channelVersion, packet)
Middleware->>App: OnRecvPacket(channelVersion, packet)
App->>Wasm: Execute contract(msg, funds)
Wasm-->>App: Exec result
App-->>Middleware: Return Acknowledgement
Middleware-->>Hooks: Return Acknowledgement
Hooks-->>Relayer: Ack handled
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsTimed out fetching pipeline failures after 30000ms Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 41.99% 42.54% +0.55%
==========================================
Files 49 49
Lines 3243 3154 -89
==========================================
- Hits 1362 1342 -20
+ Misses 1743 1675 -68
+ Partials 138 137 -1
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 228: The go.mod declares a direct dependency
github.com/shamaton/msgpack/v2 v2.2.3 which has unpatched HIGH-severity DoS
issues; remove or stop importing that module and replace it with a maintained
msgpack implementation (e.g., github.com/vmihailenco/msgpack/v5) or add a
temporary replace directive to point to a safe fork, and update any imports in
the codebase to the new module path (or adjust code to use the alternative API);
also audit why CosmWasm/wasmd@v0.61.11 pulls this dependency and, if you cannot
avoid it, document the risk and add a dependency mitigation (replace or fork) in
go.mod to prevent the vulnerable version from being used.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7cca01d7-71e8-447a-95f2-98e4fb770966
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (30)
app/abcipp.goapp/ante/ante.goapp/ante/minimal.goapp/app.goapp/app_test.goapp/genesis.goapp/getter.goapp/ibc-hooks/ack.goapp/ibc-hooks/ack_test.goapp/ibc-hooks/common_test.goapp/ibc-hooks/hooks.goapp/ibc-hooks/receive.goapp/ibc-hooks/receive_test.goapp/ibc-hooks/send.goapp/ibc-hooks/send_test.goapp/ibc-hooks/timeout.goapp/ibc-hooks/timeout_test.goapp/ibc-hooks/util.goapp/ibc-hooks/util_test.goapp/keepers/keepers.goapp/keepers/keys.goapp/modules.goapp/upgrades/v1_3_0/upgrade.goapp/wasmtesting/common_test.gocmd/minitiad/root.gogo.modx/tokenfactory/keeper/before_send.gox/tokenfactory/keeper/common_test.gox/tokenfactory/types/before_send.gox/wasmextension/keeper/common_test.go
💤 Files with no reviewable changes (4)
- app/wasmtesting/common_test.go
- x/tokenfactory/keeper/common_test.go
- x/wasmextension/keeper/common_test.go
- cmd/minitiad/root.go
beer-1
reviewed
May 8, 2026
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/keepers/keepers.go (1)
401-401: 💤 Low valueConsider extracting shared
WasmHooksinstance.The same
ibcwasmhooks.NewWasmHooks(appCodec, ac, appKeepers.WasmKeeper, appKeepers.OPChildKeeper)is instantiated twice—once for the transfer stack (line 401) and once for the wasm IBC stack (line 484). These could be consolidated into a single shared instance if the hooks are stateless.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/keepers/keepers.go` at line 401, Extract a single shared WasmHooks instance instead of calling ibcwasmhooks.NewWasmHooks(...) twice: create a variable (e.g., wasmHooks := ibcwasmhooks.NewWasmHooks(appCodec, ac, appKeepers.WasmKeeper, appKeepers.OPChildKeeper)) near the keeper initialization and reuse wasmHooks wherever NewWasmHooks(...) is currently invoked (the transfer stack and the wasm IBC stack); ensure the new variable is in scope for both usages and confirm the hooks are indeed stateless before consolidating.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@app/keepers/keepers.go`:
- Line 401: Extract a single shared WasmHooks instance instead of calling
ibcwasmhooks.NewWasmHooks(...) twice: create a variable (e.g., wasmHooks :=
ibcwasmhooks.NewWasmHooks(appCodec, ac, appKeepers.WasmKeeper,
appKeepers.OPChildKeeper)) near the keeper initialization and reuse wasmHooks
wherever NewWasmHooks(...) is currently invoked (the transfer stack and the wasm
IBC stack); ensure the new variable is in scope for both usages and confirm the
hooks are indeed stateless before consolidating.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e3d4c284-7e10-4d5d-81c1-c37e54b68493
📒 Files selected for processing (1)
app/keepers/keepers.go
beer-1
approved these changes
May 11, 2026
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 3: Update the Dockerfile's LIBWASMVM_VERSION variable to match the bumped
wasmvm module in go.mod: change LIBWASMVM_VERSION from v2.2.4 to v3.0.4 so the
Docker build uses the same wasmvm/v3 v3.0.4 version referenced in go.mod; ensure
the Dockerfile ENV or ARG named LIBWASMVM_VERSION is set to "v3.0.4" wherever
it's defined.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 08a5a01d-2d46-44f0-af11-9ad6486fc9b2
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
beer-1
reviewed
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
Dependencies
Removals
Refactor
Migrations / Upgrades