Skip to content

ci: validate format and go-fix in lint workflow - #152

Merged
beer-1 merged 2 commits into
mainfrom
ci/format-and-go-fix
Apr 6, 2026
Merged

beer-1 merged 2 commits into
mainfrom
ci/format-and-go-fix

Conversation

@beer-1

@beer-1 beer-1 commented Apr 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add format job to the lint workflow: runs make format and fails if the repo is dirty
  • Add modernize-go.yml: weekly scheduled workflow that runs go fix ./... and opens a PR automatically
  • Apply make format and go fix ./... locally (mechanical changes only)

Test plan

  • Lint workflow passes on this PR
  • No behavioral changes in the codebase (format/modernize only)

Summary by CodeRabbit

  • Chores
    • Added automated code formatting verification to the CI/CD pipeline.
    • Implemented automated Go code modernization workflow (runs weekly or on-demand).
    • Applied internal code organization improvements for consistency.

@beer-1
beer-1 requested a review from a team as a code owner April 6, 2026 08:25
@coderabbitai

coderabbitai Bot commented Apr 6, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b0f1c23a-2ca6-427f-aaaf-5b5007e64c98

📥 Commits

Reviewing files that changed from the base of the PR and between b56cc9d and 6fd800d.

📒 Files selected for processing (8)
  • .github/workflows/lint.yml
  • .github/workflows/modernize-go.yml
  • app/abcipp.go
  • app/ante/minimal.go
  • app/getter.go
  • app/keepers/keepers.go
  • app/modules.go
  • integration-tests/e2e/benchmark/config.go

Walkthrough

This pull request introduces two new GitHub Actions workflows for automated Go code maintenance and formatting checks, while applying import reorganization and whitespace alignment adjustments across multiple Go source files.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
.github/workflows/lint.yml, .github/workflows/modernize-go.yml
Added new format job to check code formatting compliance with pinned tools; added modernize-go workflow to run go fix weekly and create pull requests with modernization changes.
Go Import Reorganization
app/abcipp.go, app/ante/minimal.go, app/getter.go, app/keepers/keepers.go
Reordered import statements and adjusted spacing between import groups; no functional changes to logic or exported APIs.
Whitespace & Formatting Alignment
app/modules.go, integration-tests/e2e/benchmark/config.go
Applied consistent spacing alignment to map entries and struct field formatting; no changes to field names, types, or values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Imports tidy, workflows run,
Code now clean and well-spun,
Formatting checks, modernizing right,
Automation keeps our codebase bright! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main changes: adding format validation and go-fix capability to the lint workflow. It accurately summarizes the primary intent across multiple file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/format-and-go-fix

Comment @coderabbitai help to get the list of available commands and usage tips.

@beer-1
beer-1 merged commit d1b2b8f into main Apr 6, 2026
9 checks passed
@beer-1
beer-1 deleted the ci/format-and-go-fix branch April 6, 2026 08:30
@codecov

codecov Bot commented Apr 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.03%. Comparing base (4dc757e) to head (6fd800d).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   42.03%   42.03%           
=======================================
  Files          49       49           
  Lines        3245     3245           
=======================================
  Hits         1364     1364           
  Misses       1743     1743           
  Partials      138      138           
Files with missing lines Coverage Δ
app/abcipp.go 48.36% <ø> (ø)
app/ante/minimal.go 0.00% <ø> (ø)
app/getter.go 18.75% <ø> (ø)
app/keepers/keepers.go 0.00% <ø> (ø)
app/modules.go 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant