Skip to content

remove rave - #845

Merged
simcheolhwan merged 1 commit into
mainfrom
remove-rave
Aug 3, 2026
Merged

simcheolhwan merged 1 commit into
mainfrom
remove-rave

Conversation

@simcheolhwan

@simcheolhwan simcheolhwan commented Jul 8, 2026 •

Copy link
Copy Markdown
Collaborator

Removes mainnets/rave/ (chain.json, assetlist.json) as part of sunsetting the Rave rollup.

Do not merge until the chain is shut down. The chain is still running, so tooling still needs this entry.

Companion PR: #844 (profile hidden, mergeable now).

@coderabbitai

coderabbitai Bot commented Jul 8, 2026 •

Copy link
Copy Markdown

Walkthrough

This pull request removes the mainnets/rave/assetlist.json and mainnets/rave/chain.json files, deleting all chain metadata, endpoint configuration, and asset listings for the rave mainnet from the registry.

Changes

Cohort / File(s) Summary
Rave chain removal
mainnets/rave/assetlist.json, mainnets/rave/chain.json
Removed chain configuration and asset listing files for the rave mainnet entirely.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

With a hop and a nibble, the rave files fade,
No more chains or assets in the burrow's shade.
A clean little burrow, tidied with care,
One less carrot patch, but less to repair.
🐇✂️📄

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of the Rave chain registry files.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-rave

Comment @coderabbitai help to get the list of available commands.

@traviolus traviolus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simcheolhwan
simcheolhwan marked this pull request as ready for review August 3, 2026 07:25
@simcheolhwan
simcheolhwan merged commit b848968 into main Aug 3, 2026
13 checks passed
@simcheolhwan
simcheolhwan deleted the remove-rave branch August 3, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants