Repository navigation
fix(plugin): forward the IdentifyProjects seed options to IdentifyEnvironments - #33
Merged
Merged
Conversation
…ironments IdentifyProjectsResponse.raw_options is documented as a directory-level seed that the caller hands back to the plugin's IdentifyEnvironments for that project root, but config dropped it: IdentifyDirectory never read it, and IdentifyEnvironments never set it on the request. Carry it on the IdentificationResult and tree Node and pass it through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IdentifyProjectsResponse.raw_optionsis documented as a directory-level seed that the caller hands back to the same plugin inIdentifyEnvironmentsRequest.raw_optionsfor that project root. Config dropped it at both ends:IdentifyDirectorynever read it from the response, andIdentifyEnvironmentsnever set it on the request, so plugins couldn't carry anything they learn at identification time (such as the repository root) into environment discovery.This carries the seed on
IdentificationResultand the autodetect treeNode, and passes it toIdentifyEnvironments.Identifier.IdentifyEnvironmentsgains arawOptionsargument; nothing outside config calls it.