Skip to content

refactoring #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abmmhasan merged 1 commit into from
Aug 4, 2026
Merged

refactoring #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ different address or port when needed:
php infbyte serve --host=0.0.0.0 --port=8080
```

The built-in server is intended for local development only. Composer creates
`.env` from `.env.example` and generates a unique authentication secret without
overwriting an existing environment file.
The built-in server is intended for local development only. Composer invokes
Foundation's `app:install` command to create `.env` from `.env.example` and
generate a unique authentication secret without replacing an existing one.

The starter application exposes:

Expand All @@ -42,7 +42,7 @@ include:
| Local development | `serve`, `create:*` |
| Optional capabilities | `module:list`, `module:install`, `module:remove` |
| Database work | `db:show`, `db:table`, `db:seed`, `migrate*` |
| Runtime maintenance | `cache:clear`, `storage:link`, `secret:generate` |
| Runtime maintenance | `app:install`, `cache:clear`, `storage:link`, `secret:generate` |
| Background work | `schedule:*`, `worker:*`, `queue:consume` |
| Deployment | `optimize`, `optimize:clear`, `app:ready` |

Expand Down
77 changes: 0 additions & 77 deletions bootstrap/install.php
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "project",
"require": {
"php": ">=8.4",
"infocyph/foundation": "^1.2"
"infocyph/foundation": "^1.2.1"
},
"require-dev": {
"infocyph/phpforge": "dev-main@dev"
Expand All @@ -30,6 +30,6 @@
"sort-packages": true
},
"scripts": {
"post-create-project-cmd": "@php bootstrap/install.php"
"post-create-project-cmd": "@php infbyte app:install"
}
}
10 changes: 8 additions & 2 deletions tests/Feature/SkeletonDistributionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
}

expect($project . '/composer.json')->toBeFile()
->and($project . '/bootstrap/install.php')->toBeFile()
->and($project . '/bootstrap/install.php')->not->toBeFile()
->and($project . '/bootstrap/cache/config/.gitignore')->toBeFile()
->and($project . '/bootstrap/cache/console/.gitignore')->toBeFile()
->and($project . '/bootstrap/cache/routes/.gitignore')->toBeFile()
Expand Down Expand Up @@ -108,7 +108,13 @@
->and($exportedComposer['require']['infocyph/foundation'] ?? null)
->toBe($sourceComposer['require']['infocyph/foundation'] ?? null)
->and($exportedComposer['scripts']['post-create-project-cmd'] ?? null)
->toBe('@php bootstrap/install.php');
->toBe('@php infbyte app:install');

mkdir($project . '/vendor', 0775, true);
file_put_contents(
$project . '/vendor/autoload.php',
'<?php return require ' . var_export($root . '/vendor/autoload.php', true) . ';',
);

$installOutput = [];
$installExitCode = 0;
Expand Down