Skip to content

chore(checkout-widgets): remove the unused AXELAR_SCAN_URL constant - #2954

Merged
allan-almeida-imtbl merged 1 commit into
mainfrom
allanalmeida/bloc-588-remove-dead-axelar-scan-url
Sep 21, 2026
Merged

allan-almeida-imtbl merged 1 commit into
mainfrom
allanalmeida/bloc-588-remove-dead-axelar-scan-url

Conversation

@allan-almeida-imtbl

Copy link
Copy Markdown
Contributor
  • PR is titled with conventional commit style naming: type(scope): message
  • Breaking change marker not needed: the constant is not exported from any published entry point

Summary

Remove the unused AXELAR_SCAN_URL constant from checkout/widgets-lib. Linear: BLOC-588 (parent BLOC-558, Axelar dead-code cleanup for the zkEVM → OP Stack migration).

Detail and impact of the change

Removed

  • AXELAR_SCAN_URL (per-environment Axelarscan GMP base URLs) and its doc comment in packages/checkout/widgets-lib/src/lib/constants.ts. No file in the repo imports it. The add-tokens and purchase widgets that still link to Axelarscan build the URL inline from the Squid transaction hash and are untouched.

Anything else worth calling out?

Behaviour change: none. Widgets-lib is internal to the widgets bundle, so nothing consumer-facing changes. Verification is the repo-wide grep (only the definition matched) plus CI lint and typecheck for checkout-widgets; a local tsc in a fresh worktree needs the workspace packages built first, so the CI run is the gate here.

🤖 Generated with Claude Code

Nothing in the repo imports it; the Axelar-bridge flows that once linked to
Axelarscan by environment are gone, and the Squid-based add-tokens and purchase
widgets build their Axelarscan link inline. The Axelar bridge itself retires
with the zkEVM to OP Stack migration, so the constant has no future caller.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@allan-almeida-imtbl
allan-almeida-imtbl requested a review from a team as a code owner September 21, 2026 00:54
@nx-cloud

nx-cloud Bot commented Sep 21, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 0d4560a

Command Status Duration Result
nx affected -t build,test ✅ Succeeded 1m 7s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-09-21 00:58:04 UTC

@allan-almeida-imtbl

Copy link
Copy Markdown
Contributor Author

Verification that nothing consumes AXELAR_SCAN_URL

Checked on main (3aaa44d64):

  1. In-repo. The only match for AXELAR_SCAN_URL in any file type is the definition. src/lib/index.ts re-exports * from './constants' and 24 files import that barrel, but none names this constant; there is no namespace import (import * as) of lib/constants that could reach it dynamically.

  2. History. The last consumer was components/Transactions/TransactionList.tsx (setLink(AXELAR_SCAN_URL[checkout.config.environment])), removed in fix(checkout-widgets): Fetch pending withdrawals from the bridge contract #2680 (cce02d68c, 2025-08-19). Nothing has referenced it since.

  3. Published package. In @imtbl/checkout-widgets@2.24.9 the constant survives only as an orphan declaration in dist/types/lib/constants.d.ts. The package entry (dist/types/index.d.ts → ./factory) does not re-export lib, and the exports map exposes only the root, so no consumer can import it. The runtime bundle does not contain the constant's URLs at all (testnet.axelarscan.io/gmp/ is absent); the only Axelarscan string in dist/browser is the inline template the add-tokens and purchase widgets build from the Squid tx hash, which this PR does not touch. @imtbl/sdk@2.24.9 likewise has no trace of it.

  4. Org-wide GitHub code search. Outside this repo the name appears only in immutable/prodsec-malicious-hub-app, which vendors a 2023-era copy of widgets-lib (including the old TransactionList.tsx); it is a snapshot for security research, not a package consumer.

@allan-almeida-imtbl
allan-almeida-imtbl added this pull request to the merge queue Sep 21, 2026
Merged via the queue into main with commit 00aa36c Sep 21, 2026
7 checks passed
@allan-almeida-imtbl
allan-almeida-imtbl deleted the allanalmeida/bloc-588-remove-dead-axelar-scan-url branch September 21, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants