Repository navigation
Create strings.po - #321
wabisabi926 wants to merge 0 commit into
Conversation
|
1 similar comment
|
im85288
left a comment
im85288
left a comment
There was a problem hiding this comment.
Thanks for the Simplified Chinese translation! All string IDs from en_gb are covered. A few things to fix before merging:
Must fix
- Revert the
xbmc.pythonbump inaddon.xml(see inline) — it breaks Kodi 18 builds. - Please move the v1.1.9
<news>entry out of this PR; it's unrelated to the translation. - #30036 and #30600 have mistranslations (see inline).
Nice to have
- A few smaller translation / header / whitespace nits inline.
- This PR is opened from your fork's
masterbranch, so anything else pushed there will land here too — a dedicated branch is safer for future PRs.
| <addon id="service.upnext" name="Up Next" version="1.1.9" provider-name="im85288"> | ||
| <requires> | ||
| <import addon="xbmc.python" version="2.25.0"/> | ||
| <import addon="xbmc.python" version="3.0.0"/> |
There was a problem hiding this comment.
Please revert this to 2.25.0. The Makefile (KODI_PYTHON_ABIS := 3.0.0 2.25.0) rewrites this value per build at release time, producing separate Kodi 18 and Kodi 19+ (+matrix.1) packages. Hardcoding 3.0.0 in source breaks the Kodi 18 build, and is unrelated to the translation.
| </extension> | ||
| <extension point="xbmc.service" library="resources/lib/service_entry.py"/> | ||
| <extension point="xbmc.addon.metadata"> | ||
| <extension point="xbmc.addon.metadata"> |
There was a problem hiding this comment.
Nit: trailing whitespace here and an extra blank line on the next line.
| <summary lang="zh_CN">建议自动播放下一集</summary> | ||
| <description lang="zh_CN">一个服务插件，显示观看下一集的 Netflix 样式通知。在几次自动迭代之后，它会询问用户是否仍在观看。 | ||
|
|
||
| 许多现有的插件已经开箱即用地与该服务集成。</description> |
There was a problem hiding this comment.
Nit: trailing whitespace after </description>.
| <platform>all</platform> | ||
| <license>GPL-2.0-only</license> | ||
| <news> | ||
| v1.1.9 (2023-05-10) |
There was a problem hiding this comment.
This v1.1.9 changelog entry isn't related to the translation — please drop it from this PR; changelog updates are handled separately at release time.
| "POT-Creation-Date: YEAR-MO-DA HO:MI+ZONE\n" | ||
| "PO-Revision-Date: 2026-04-18 16:21+0800\n" | ||
| "Last-Translator: wabisabi926\n" | ||
| "Language-Team: Traditional Chinese\n" |
There was a problem hiding this comment.
zh_CN is Simplified Chinese — this looks copied from the zh_TW file. Suggest Language-Team: Chinese (Simplified).
|
|
||
| msgctxt "#30036" | ||
| msgid "Up next in [COLOR FFFF4081]$INFO[Window.Property(remaining)][/COLOR] seconds" | ||
| msgstr "在 [COLOR FFFF4081]$INFO[Window.Property(remaining)][/COLOR] 秒后继续播放" |
There was a problem hiding this comment.
This is identical to #30035 ("Continue watching in…" → 继续播放), but #30036 is "Up next in…". Suggest something like 在 [COLOR FFFF4081]$INFO[Window.Property(remaining)][/COLOR] 秒后播放下一个.
|
|
||
| msgctxt "#30505" | ||
| msgid "Show a \"Stop\" button instead of a \"Close\" button" | ||
| msgstr "显示 \"停止播放\" 按钮而非 \"关闭\" 按钮" |
There was a problem hiding this comment.
The button label #30033 is translated as 停止, so this should refer to it as "停止" rather than "停止播放" to match what users actually see.
|
|
||
| msgctxt "#30600" | ||
| msgid "Behaviour" | ||
| msgstr "风格" |
There was a problem hiding this comment.
风格 means "style". "Behaviour" here is the settings category for playback behaviour — suggest 行为.
|
|
||
| msgctxt "#30613" | ||
| msgid "All episodes [COLOR gray]any length[/COLOR]" | ||
| msgstr "所有剧集 [COLOR gray] 任意长度[/COLOR]" |
There was a problem hiding this comment.
Nit: a space was added inside the colour tag ([COLOR gray] 任意长度). Suggest 所有剧集 [COLOR gray]任意长度[/COLOR] to match the source formatting.
|
|
||
| msgctxt "#30617" | ||
| msgid "Short episodes [COLOR gray]> 10 mins[/COLOR]" | ||
| msgstr "短剧 [COLOR gray]> 10 分钟[/COLOR]" |
There was a problem hiding this comment.
短剧 is commonly read as the "short drama" genre. Suggest 短篇剧集 for consistency with 中篇剧集 / 长篇剧集.
|
Thanks again for the translation, @wabisabi926! This PR now conflicts with master, and a couple of its changes have been overtaken since my review:
Rebasing onto current master (or starting a fresh branch with just |
2 participants
Chinese