Repository navigation
Update README - #48
Merged
Merged
Conversation
bernardnormier
requested review from
InsertCreativityHere,
Copilot,
externl and
pepone
June 2, 2026 22:05
There was a problem hiding this comment.
Pull request overview
Updates the repository README to better describe the Slice definitions layout and clarify how other IceRPC implementations should synchronize/consume these Slice files.
Changes:
- Clarified the purpose of
IceRpc/Iceand linked to Ice’s original Slice language documentation. - Updated guidance on where the authoritative Slice definitions live and referenced the
sync-slice.pyworkflow inicerpc-csharp. - Refreshed/cleaned up link references (including updating the Slice docs link).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+12
to
+13
| The copy of record for these Slice files is in this repository. Each IceRPC implementation is expected to create its | ||
| own exact clone of these Slice files. See for example the [sync-slice.py] Python script in icerpc-csharp. |
externl
approved these changes
Jun 3, 2026
pepone
approved these changes
Jun 3, 2026
InsertCreativityHere
approved these changes
Jun 3, 2026
InsertCreativityHere
left a comment
InsertCreativityHere
left a comment
Member
There was a problem hiding this comment.
Looks good to me!
Just minor things.
Co-authored-by: Austin Henriksen <austin.r.henriksen79@gmail.com>
Co-authored-by: Austin Henriksen <austin.r.henriksen79@gmail.com>
Co-authored-by: Austin Henriksen <austin.r.henriksen79@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.