Repository navigation
Replace cs::namespace with cs::identifier - #46
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Slice metadata annotations to use cs::identifier instead of cs::namespace, aligning these shared Slice definitions with the newer C# mapping metadata.
Changes:
- Replaced
[cs::namespace("…")]with[cs::identifier("…")]in well-known type definitions. - Replaced
[cs::namespace("…")]with[cs::identifier("…")]for the IceRpcServiceAddresscustom type.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| WellKnownTypes/Uuid.slice | Switches C# metadata annotation to cs::identifier for the UUID well-known type. |
| WellKnownTypes/Uri.slice | Switches C# metadata annotation to cs::identifier for the URI well-known type. |
| WellKnownTypes/TimeStamp.slice | Switches C# metadata annotation to cs::identifier for the timestamp well-known type. |
| WellKnownTypes/Duration.slice | Switches C# metadata annotation to cs::identifier for the duration well-known type. |
| IceRpc/ServiceAddress.slice | Switches C# metadata annotation to cs::identifier for ServiceAddress. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
InsertCreativityHere
approved these changes
Apr 8, 2026
InsertCreativityHere
left a comment
Member
There was a problem hiding this comment.
Looks good. Should probably merge these before the main icerpc-csharp PR, so it can pull in these updated files.
bernardnormier
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
companion PR for icerpc/icerpc-csharp#4382