Skip to content

Replace cs::namespace with cs::identifier - #46

Merged
pepone merged 1 commit into
icerpc:mainfrom
pepone:cs-identifier
Apr 8, 2026
Merged

pepone merged 1 commit into
icerpc:mainfrom
pepone:cs-identifier

Conversation

@pepone

@pepone pepone commented Apr 8, 2026 •

Copy link
Copy Markdown
Member

companion PR for icerpc/icerpc-csharp#4382

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Slice metadata annotations to use cs::identifier instead of cs::namespace, aligning these shared Slice definitions with the newer C# mapping metadata.

Changes:

  • Replaced [cs::namespace("…")] with [cs::identifier("…")] in well-known type definitions.
  • Replaced [cs::namespace("…")] with [cs::identifier("…")] for the IceRpc ServiceAddress custom type.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
WellKnownTypes/Uuid.slice Switches C# metadata annotation to cs::identifier for the UUID well-known type.
WellKnownTypes/Uri.slice Switches C# metadata annotation to cs::identifier for the URI well-known type.
WellKnownTypes/TimeStamp.slice Switches C# metadata annotation to cs::identifier for the timestamp well-known type.
WellKnownTypes/Duration.slice Switches C# metadata annotation to cs::identifier for the duration well-known type.
IceRpc/ServiceAddress.slice Switches C# metadata annotation to cs::identifier for ServiceAddress.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@InsertCreativityHere InsertCreativityHere left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should probably merge these before the main icerpc-csharp PR, so it can pull in these updated files.

@pepone
pepone merged commit 5196667 into icerpc:main Apr 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants