Repository navigation
Moved the Slice Compiler Definitions from icerpc-slice -> slicec - #45
Merged
InsertCreativityHere merged 1 commit intoMar 19, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the Slice compiler definition files from this repository now that they live in slicec, and updates the top-level README to reflect the remaining directory layout for consumers cloning these Slice definitions.
Changes:
- Removed the
Compiler/*Slice definition files (compiler symbol model and code generator interfaces). - Updated
README.mdto drop theCompilerand top-levelIcerows and point Ice interop definitions toIceRpc/Ice.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updates the directory table to match the new layout (no Compiler/, Ice interop under IceRpc/Ice). |
| Compiler/SyntaxElements.slice | Removes compiler symbol/type model definitions from this repo. |
| Compiler/DocComment.slice | Removes doc comment model definitions from this repo. |
| Compiler/CodeGenerator.slice | Removes code generator interface and related types from this repo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pepone
approved these changes
Mar 19, 2026
bernardnormier
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the Slice compiler definitions live in
slicec(icerpc/slicec#737), we should delete them fromicerpc-slice.