Repository navigation
Conversation
Selecting text with `.selectable(true)` did not work inside panes due to `shell.capture_event()` swallowing the event when cursor was within bounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI: I pulled upstream to try the new text selection API. It did not work inside a
pane_gridwidget.This debug is partly AI slop. I think
shell.capture_event()swallowed the click event when the cursor was within pane bounds. However, button pressing still did work. Anyhow, the patch works for me in a pretty extensivepane_gridsetup. Moving, clicking, resizing panes etc works. I have not run any official tests.Just a heads up.