Skip to content

SDL_GPU: Prevent allocating/copying uniform buffers when possible #72

Description

@flibitijibibo

sdlgpu.c's update_uniform_buffer function stands out in profiles of FNA3D trace data. For OpenGL we were able to reduce glUniform's impact on CPU performance by memcmp'ing the buffer first, and only pushing when a change actually happened...

https://github.com/icculus/mojoshader/blob/main/mojoshader_opengl.c#L2813

... but sdlgpu.c currently allocs a buffer for every constant buffer push:

https://github.com/icculus/mojoshader/blob/main/mojoshader_sdlgpu.c#L195

We should try to remove this middle buffer and shadow buffer state, this can improve performance quite a bit!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions