Skip to content

fix: upgrade picomatch to 2.3.2 to remediate CVE-2026-33671 - #395

Merged
aswinayyolath merged 1 commit into
ibm-messaging:masterfrom
Meenu-Mariya:issue-394
Jul 23, 2026
Merged

aswinayyolath merged 1 commit into
ibm-messaging:masterfrom
Meenu-Mariya:issue-394

Conversation

@Meenu-Mariya

Copy link
Copy Markdown
Contributor

Contributes to: #394

Status

READY

Commit Message

fix: upgrade picomatch to 2.3.2 to remediate CVE-2026-33671

Contributes to: #394

Signed-off-by: Meenu Mariya Meenu.Mariya@ibm.com

Contributes to: ibm-messaging#394

Signed-off-by: Meenu Mariya <Meenu.Mariya@email.com>
@Meenu-Mariya
Meenu-Mariya requested a review from Adil9645 July 23, 2026 07:05

@Adil9645 Adil9645 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread ui/package.json
"@babel/runtime": "^7.26.10",
"semver":"7.5.2"
"semver":"7.5.2",
"picomatch": "2.3.2"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this change required?

@aswinayyolath aswinayyolath Jul 23, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're overriding picomatch dependency to get rid of the CVE

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since picomatch comes as part of a transitive dependecy , i need to override it.
It's pulled in by fast-glob, micromatch, anymatch, and readdirp

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

carbon-components and carbon-components-react needs a minor version changes few other packages(sass, babel-jest,webpack,lint-staged) . These upgrades could lead to breaking changes. Hence, for now the option is to override.

@aswinayyolath
aswinayyolath merged commit 7aaca9f into ibm-messaging:master Jul 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants