Repository navigation
Open
Conversation
praiyani6789
approved these changes
Oct 23, 2026
| return | ||
|
|
||
| # Already on 9.2+: routingMode=path was set intentionally, do not block | ||
| if currentChannel and isVersionEqualOrAfter("9.2.0", currentChannel): |
Contributor
There was a problem hiding this comment.
Should we not need to consider the upgrade plan for the unsupported 9.2 catalog to the 9.3 FC release? If someone upgrades from the unsupported 9.2 catalog to 9.3 FC where the Suite CR spec contains the routingMode path then it might create a problem.. or can we assume that prior to upgrading users must always update the latest 9.2 patch which contains PBR support? 🤔
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a version of the cli which added routingMode into the suiteCR so it's possible for clusters to have it set but for the operator to not look at it. When upgrading to 9.2 or updating from an early 9.2 version if it is set to path then the operator will try to change pathing modes which isn't supported.
Output of a test where injecting routingMode into the suite CR of a test system prior to trying an upgrade:
We don't have to worry about upgrade from an early 9.2 patch to 9.3, as 9.3 feature channel wasn't added until after 9.2 supported path based routing.