Skip to content

[PATCH] detect if routingMode set prior to upgrade/update to version that supports path based routing - #2661

Open
IanBoden wants to merge 2 commits into
masterfrom
ib-pbr
Open

IanBoden wants to merge 2 commits into
masterfrom
ib-pbr

Conversation

@IanBoden

Copy link
Copy Markdown
Contributor

There was a version of the cli which added routingMode into the suiteCR so it's possible for clusters to have it set but for the operator to not look at it. When upgrading to 9.2 or updating from an early 9.2 version if it is set to path then the operator will try to change pathing modes which isn't supported.

Output of a test where injecting routingMode into the suite CR of a test system prior to trying an upgrade:

  1. Set Target OpenShift Cluster
    Already connected to OCP Cluster:
    https://console-openshift-console.fvt811x-6f1620198115433da1cac8216c06779b-0000.us-south.containers.appdomain.cloud

Proceed with this cluster? [y/n] y

  1. Instance Selection
    Select a MAS instance to upgrade from the list below:
  • fvt811x v8.11.35-pre.maint811xdev

Enter MAS instance ID: fvt811x
Custom channel 9.2.x-dev
Fatal Error: Cannot upgrade to 9.2.x-dev: spec.settings.routingMode is set to "path" on the Suite CR.

This value was accidentally written to pre-9.2 Suite CRs and will cause the upgrade
pipeline to attempt an unintended routing mode switch.

To resolve this, remove the field from the Suite CR before retrying the upgrade:

oc patch suite fvt811x -n mas-fvt811x-core --type=json
-p '[{"op":"remove","path":"/spec/settings/routingMode"}]'

After applying the patch, re-run the upgrade.

We don't have to worry about upgrade from an early 9.2 patch to 9.3, as 9.3 feature channel wasn't added until after 9.2 supported path based routing.

@IanBoden
IanBoden requested a review from a team as a code owner October 23, 2026 10:25
@IanBoden
IanBoden requested a review from praiyani6789 October 23, 2026 10:25
return

# Already on 9.2+: routingMode=path was set intentionally, do not block
if currentChannel and isVersionEqualOrAfter("9.2.0", currentChannel):

@dixitgsathwara dixitgsathwara Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not need to consider the upgrade plan for the unsupported 9.2 catalog to the 9.3 FC release? If someone upgrades from the unsupported 9.2 catalog to 9.3 FC where the Suite CR spec contains the routingMode path then it might create a problem.. or can we assume that prior to upgrading users must always update the latest 9.2 patch which contains PBR support? 🤔

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants