Fix use of weak cryptographic hash function (MD5) - #5536
Open
apocalypse9949 wants to merge 1 commit into
Open
Conversation
Signed-off-by: apocalypse9949 <125962989+apocalypse9949@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Replaced the vulnerable MD5 hashing algorithm with the secure SHA256 algorithm in
common/deliverclient/orderers/connection.gofor theEndpoint.String()function. Also removed the unused"crypto/md5"import.Reason: MD5 is a weak cryptographic hash function that is vulnerable to collision attacks. This means malicious actors could potentially generate an identical hash for a different endpoint certificate, leading to spoofed endpoints or misleading debug outputs, which poses a security risk in a system handling certificates.
Changed Switched the cryptographic hash function to
sha256, which is a secure, modern hash function. The output continues to be correctly handled as a hexadecimal string byfmt.Sprintf("%X", hash), safely supporting the longer 64-character hash length. All unit tests successfully run.