Skip to content

Revert "perf(header): optimize HeaderValue creation via zero-copy sharing" - #924

Merged
seanmonstar merged 1 commit into
hyperium:masterfrom
0x676e67:revert-884-patch-1
Jul 23, 2026
Merged

Revert "perf(header): optimize HeaderValue creation via zero-copy sharing"#924
seanmonstar merged 1 commit into
hyperium:masterfrom
0x676e67:revert-884-patch-1

Conversation

@0x676e67

@0x676e67 0x676e67 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

close: #923

@0x676e67
0x676e67 marked this pull request as ready for review July 22, 2026 19:04
@0x676e67
0x676e67 marked this pull request as draft July 23, 2026 01:33
@0x676e67
0x676e67 marked this pull request as ready for review July 23, 2026 17:32
@seanmonstar

seanmonstar commented Jul 23, 2026

Copy link
Copy Markdown
Member

Thanks! Just for history sake, I've been trying to find why we made that change originally. But I cannot find an issue anywhere describing it. I vaguely remember someone showing a flamegraph pointing at that function? Or it's all blurring together...

@0x676e67

0x676e67 commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I think.

#883

@seanmonstar

seanmonstar commented Jul 23, 2026

Copy link
Copy Markdown
Member

Hm, I mean maybe. But it doesn't quite look like as closely related as I thought. My memory fails me. Oh well, yea let's revert for now. Thanks!

@seanmonstar
seanmonstar merged commit 9416dc8 into hyperium:master Jul 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Suspected memory usage regression since 0.4.14: zero-copy HeaderValue decoding (#884) pins connection read buffers

2 participants

@0x676e67 @seanmonstar