Fix macOS/Windows CI build failure: missing jsonschema module for mbedtls codegen - #8
Merged
Merged
Conversation
Co-authored-by: Lord-Grey <48840279+Lord-Grey@users.noreply.github.com>
Co-authored-by: Lord-Grey <48840279+Lord-Grey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job for Windows
Fix macOS/Windows CI build failure: missing Sep 6, 2026
jsonschema module for mbedtls codegen
Co-authored-by: Lord-Grey <48840279+Lord-Grey@users.noreply.github.com>
Lord-Grey
approved these changes
Sep 6, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The workflow change directly addresses the missing Python dependency on macOS/Windows runners and is low-risk and localized to CI.
Pull request overview
Updates the Qt 5/6 GitHub Actions workflow to ensure the Python modules needed by mbedTLS/TF-PSA-Crypto code generation are present on GitHub-hosted runners, preventing macOS/Windows CI failures due to missing dependencies.
Changes:
- Add a pip-install step for
jsonschema>=3.2.0andjinja2>=2.10.3on macOS before the build. - Add an equivalent pip-install step on Windows after
actions/setup-python.
File summaries
| File | Description |
|---|---|
| .github/workflows/qt5_6.yml | Installs required Python deps on macOS/Windows runners so mbedTLS codegen during the build doesn’t fail due to missing modules. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+120
to
+121
| - name: 📥 Install Python dependencies | ||
| run: python3 -m pip install "jsonschema>=3.2.0" "jinja2>=2.10.3" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS build job was failing with
ModuleNotFoundError: No module named 'jsonschema', breaking the CI pipeline.Root cause
mbedtls's
tf-psa-crypto/scripts/generate_driver_wrappers.pyscript runs during the CMake build to generatepsa_crypto_driver_wrappers.h, and importsjsonschema. This package isn't preinstalled on the GitHub-hosted macOS/Windows runners, causing the build step to fail.Changes
pip install "jsonschema>=3.2.0"before the build step.pip installstep after Python setup, since the same generator script runs there as well.>=3.2.0, matching the requirement declared in mbedtls's own upstreamdriver.requirements.txt, for reproducible builds.