Skip to content

Fix macOS/Windows CI build failure: missing jsonschema module for mbedtls codegen - #8

Merged
Lord-Grey merged 4 commits into
mainfrom
copilot/fix-github-actions-job-again
Sep 6, 2026
Merged

Fix macOS/Windows CI build failure: missing jsonschema module for mbedtls codegen#8
Lord-Grey merged 4 commits into
mainfrom
copilot/fix-github-actions-job-again

Conversation

Copilot AI commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

The macOS build job was failing with ModuleNotFoundError: No module named 'jsonschema', breaking the CI pipeline.

Root cause

mbedtls's tf-psa-crypto/scripts/generate_driver_wrappers.py script runs during the CMake build to generate psa_crypto_driver_wrappers.h, and imports jsonschema. This package isn't preinstalled on the GitHub-hosted macOS/Windows runners, causing the build step to fail.

Changes

  • macOS job: added a step to pip install "jsonschema>=3.2.0" before the build step.
  • Windows job: added the equivalent pip install step after Python setup, since the same generator script runs there as well.
  • Pinned the minimum version to >=3.2.0, matching the requirement declared in mbedtls's own upstream driver.requirements.txt, for reproducible builds.
- name: 📥 Install Python dependencies
  run: python3 -m pip install "jsonschema>=3.2.0"

- name: 👷 Build
  ...

Copilot AI and others added 2 commits September 6, 2026 18:24
Co-authored-by: Lord-Grey <48840279+Lord-Grey@users.noreply.github.com>
Co-authored-by: Lord-Grey <48840279+Lord-Grey@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job for Windows Fix macOS/Windows CI build failure: missing jsonschema module for mbedtls codegen Sep 6, 2026
Copilot AI requested a review from Lord-Grey September 6, 2026 18:26
Co-authored-by: Lord-Grey <48840279+Lord-Grey@users.noreply.github.com>
@Lord-Grey
Lord-Grey marked this pull request as ready for review September 6, 2026 18:35
Copilot AI lite review requested due to automatic review settings September 6, 2026 18:35
@Lord-Grey
Lord-Grey merged commit 37d66f1 into main Sep 6, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The workflow change directly addresses the missing Python dependency on macOS/Windows runners and is low-risk and localized to CI.

Pull request overview

Updates the Qt 5/6 GitHub Actions workflow to ensure the Python modules needed by mbedTLS/TF-PSA-Crypto code generation are present on GitHub-hosted runners, preventing macOS/Windows CI failures due to missing dependencies.

Changes:

  • Add a pip-install step for jsonschema>=3.2.0 and jinja2>=2.10.3 on macOS before the build.
  • Add an equivalent pip-install step on Windows after actions/setup-python.
File summaries
File Description
.github/workflows/qt5_6.yml Installs required Python deps on macOS/Windows runners so mbedTLS codegen during the build doesn’t fail due to missing modules.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +120 to +121
- name: 📥 Install Python dependencies
run: python3 -m pip install "jsonschema>=3.2.0" "jinja2>=2.10.3"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants