feat: update Taffy revision - #55
Merged
Merged
Conversation
hyfdev
commented
Aug 23, 2026
hyfdev
left a comment
Owner
Author
There was a problem hiding this comment.
Adversarial review complete.
- Audited all 18 upstream commits between the old and new Taffy revisions, including public structs, feature closure, transitive dependencies, TaffyTree/NodeId signatures, panic boundaries, and generated transports.
- Exercised every Contain value plus invalid numbers and non-number inputs; failures remain controlled and updateStyle remains atomic.
- Exercised Detailed Grid under RTL with positive implicit tracks and named lines. This exposed a missing regression case, now covered by commit 271dc13.
- Corrected the squash title from chore to feat so the Core release planner can select a version without marking the change breaking.
- Verified no stale old revision, contentSize, sizes/gutters, wire-v1, or 21-slot Layout references remain outside intentional migration/history text.
- Re-ran pnpm vp run check and pnpm vp run check:wasm: 238 Core tests pass on native and Wasm; Yoga remains 557 passed, 84 expected failures, 17 skipped. All GitHub checks pass on Ubuntu, Windows, Wasm, Node, Rust, and PR title.
No remaining review findings or merge blockers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Benchmark note
Three website benchmark refresh attempts were rejected by the existing stability gates in different scenarios. No unstable dataset was written; the pending refresh and retained dataset source are recorded in technology-stack.md.