refactor(node): use raw Taffy node IDs - #54
Merged
Conversation
Owner
Author
Adversarial reviewReviewed the change by trying to break these assumptions:
Findings fixed during the review:
The project owner classified this PR as a normal refactor rather than a breaking release change, so its squash title remains refactor(node): use raw Taffy node IDs. No unresolved implementation findings remain. Local pnpm vp run check and pnpm vp run check:wasm pass. GitHub CI is 6/6 green across Ubuntu, Windows, Wasm, Node, Rust, and the PR-title check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contract
A NodeId is supported only while its node is live and only with the TaffyTree that returned it. Independent trees may issue equal raw values. Forged, foreign, and stale in-range values are unsupported and have no stable error classification.
Verification