Add __repr__ methods for DatasetColumn and DatasetColumnPair#765
Open
zanvari wants to merge 1 commit into
Open
Add __repr__ methods for DatasetColumn and DatasetColumnPair#765zanvari wants to merge 1 commit into
zanvari wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #547 by adding
__repr__()implementations forDatasetColumnandDatasetColumnPair.Currently, both classes inherit from
listbut do not populate the underlying list. As a result, printing either object displays[], even though they provide lazy access to dataset columns. This can make debugging difficult and lead to confusing exception messages and logs.The new representations provide a concise summary of each object without loading dataset contents into memory. For
DatasetColumn, the representation includes the column key and dataset length. ForDatasetColumnPair, it includes the configured column names, key mappings, and dataset length.Changes
__repr__()toDatasetColumn__repr__()toDatasetColumnPairExample
Before:
After:
Similarly,
DatasetColumnPairnow provides a meaningful representation instead of displaying as an empty list.Testing
I added tests for both classes and verified that the new representations are returned as expected.
Result:
Fixes #547.