Repository navigation
Unit1: update to LunarLander-v3 and bump dependency versions - #713
Open
MaxenceQueyrel wants to merge 1 commit into
Open
MaxenceQueyrel wants to merge 1 commit into
MaxenceQueyrel wants to merge 1 commit into
Conversation
- Switch LunarLander-v2 -> LunarLander-v3 in the environment creation, training, evaluation, model save, and hub push cells (Gymnasium deprecated LunarLander-v2 in favor of v3). - Bump requirements-unit1.txt pins: stable-baselines3==2.9.0, swig==4.4.1, gymnasium[box2d]==1.3.0, huggingface_sb3==3.0. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
unit1.ipynbandrequirements-unit1.txthad drifted from the (already-fixed)unit1_correction.ipynb/requirements-unit1_correction.txt. This PR ports the same fixes over to the student-facing files.unit1.ipynbLunarLander-v2→LunarLander-v3in the cells that actually instantiate/train/evaluate/save/push the environment (env creation, vectorized env creation, model save name, eval env, hubrepo_id/commit message), matching exactly whatunit1_correction.ipynbalready does.LunarLander-v2untouched, along with the pretrained demo checkpoint (Classroom-workshop/assignment2-omar,ppo-LunarLander-v2.zip) and the hostedsb3/ppo-LunarLander-v2replay video, since those point at real external v2 artifacts and the correction notebook leaves them as-is too.requirements-unit1.txtSame 4 dependencies as before, versions bumped to match
requirements-unit1_correction.txt's pins:stable-baselines3==2.0.0a5→2.9.0swig→4.4.1gymnasium[box2d](unpinned) →1.3.0huggingface_sb3(unpinned) →3.0Why
Gymnasium deprecated
LunarLander-v2in favor ofv3, and the pinned dependency versions inrequirements-unit1.txtare outdated relative to what's needed to actually run the notebook today, causing install/runtime friction for learners following Unit 1.🤖 Generated with Claude Code