Strip literal '^[' ANSI escapes in test output cleaning - #2137
Merged
Merged
Conversation
The buildpack emits ANSI colour codes on error/warning banners. On GitHub Actions runners the escape byte arrives as the two literal characters `^[` instead of 0x1B, so `clean_output`'s regex (which only matched real ESC) left them in and broke output-matching assertions across the integration-test suite. Widen the regex to strip both variants, mirroring heroku/heroku-buildpack-java#303. GUS-W-24073123.
edmorley
marked this pull request as ready for review
September 2, 2026 13:28
edmorley
enabled auto-merge (squash)
September 2, 2026 13:28
This was referenced Sep 2, 2026
runesoerensen
approved these changes
Sep 2, 2026
Merged
edmorley
added a commit
to heroku/heroku-buildpack-dotnet
that referenced
this pull request
Sep 5, 2026
The buildpack emits ANSI colour codes on error/warning banners. On GitHub Actions runners the escape byte arrives as the two literal characters `^[` instead of 0x1B, so `clean_output`'s regex (which only matched real ESC) left them in and broke output-matching assertions across the integration-test suite. Widen the regex to strip both variants, mirroring heroku/heroku-buildpack-python#2137 and heroku/heroku-buildpack-java#303. GUS-W-24100567.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buildpack emits ANSI colour codes on error/warning banners. On GitHub Actions runners the escape byte arrives as the two literal characters
^[instead of 0x1B, soclean_output's regex (which only matched real ESC) left them in and broke output-matching assertions across the integration-test suite.eg:
https://github.com/heroku/heroku-buildpack-python/actions/runs/33632972131/job/100259966770#step:5:623
Widen the regex to strip both variants, mirroring heroku/heroku-buildpack-java#303.
GUS-W-24073123.