Skip to content

ETT-1600: retire alicorn - #249

Open
carylwyatt wants to merge 13 commits into
mainfrom
ETT-1600-retire-alicorn
Open

ETT-1600: retire alicorn#249
carylwyatt wants to merge 13 commits into
mainfrom
ETT-1600-retire-alicorn

Conversation

@carylwyatt

@carylwyatt carylwyatt commented Aug 26, 2026

Copy link
Copy Markdown
Member

This fix removes alicorn and 2021 from the skin options. In pt, I left crms as an option as a skin class name in the html, but removed the others since there's only firebird now. I looked all over for any evidence that the class skin-default (or skin-alicorn, skin-2021) was tied to anything, but if it's doing anything, I can't find it. I was originally planning on using the skin-default class in a playwright test to check that skin=alicorn param falls back to the firebird theme, but it felt silly to keep a class in the code that we don't actually use for anything. I changed the test to locate hathi-website-header, which doesn't exist in the alicorn theme.

At first I wasn't too happy with this fix because Skin.pm sets the <Skin> tag to whatever is passed in via the skin= query param. But then I realized it's only doing that in dev environments, which I think is the point of the skin param, so that's fine.

I don't know a lot about perl and I have a question about this ASSERT:

ASSERT(grep(/$skin_name/, keys %g_skin_map), qq{Skin=$skin_name not found in skin map});

This isn't throwing an error I don't think, but is it getting logged somewhere every time there's a request for a skin that isn't on the list?

Removal of alicorn directories and stylesheets

image

Unsurprisingly, there was a lot of legacy stuff to go through in here.

I tested ls, mb, pt, and wayf on dev-3 and everything seems fine. Playwright tests are passing for pt.

I left some comments in the diff but this was mainly just deleting anything in /alicorn directories and cleaning up files that used the stylesheets or other alicorn-related functions.

@carylwyatt
carylwyatt requested review from aelkiss and removed request for aelkiss August 26, 2026 19:00
my $config = $C->get_object('MdpConfig');
my $records_per_page = $config->get('default_records_per_page');

if ( $total_records > $records_per_page && $cgi->param('skin') ne 'alicorn' ) {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skin will never equal alicorn (or it could, but there won't be a corresponding theme to load), so I removed this bit from the conditional

return $s;
}

sub handle_CACHE_TIMESTAMP_PI

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was only ever used with alicorn assets.

Comment thread pt/web/reports/401.html
<head>
<title>Unauthorized</title>
<link rel="stylesheet" type="text/css" href="/common/alicorn/css/main.201910.css" />
<script type="text/javascript" src="/common/alicorn/js/utils.201910.js"></script>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not even sure these reports live in pt anymore, but I removed the stylesheet in here for good measure.

Comment thread pt/web/503_index.html

<head>
<title>Indexing in Progress | HathiTrust Digital Library</title>
<link rel="stylesheet" type="text/css" href="/common/alicorn/css/main.201910.css" />

@carylwyatt carylwyatt Aug 27, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PT does use this file, which I found out when testing pt-search for Lianet a couple months ago, but it's only ever returned as a response from search.choke and we never see the UI in page turner. There is no modal with this info in it, I only saw the text as a response in the network tab of my browser.

I only removed the stylesheet here, but this could probably use a rework at some point.

The rest of the "changes" here are linting/formatting.

Comment thread mdp-web/bookmarklet.html

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed a few ancient html pages and unused stylesheets.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this one after determining that it isn't called from anywhere anymore. I could see that it used to be called (in ls.choke, for example), but I couldn't find evidence of that for current-day ls.

@carylwyatt
carylwyatt requested a review from aelkiss August 27, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant