feat: remove Windows tray icon functionality - #1
Open
hashbk wants to merge 1 commit into
Open
Conversation
Remove all tray icon related code, dependencies, and MSI installer configuration for the Windows client. The tray icon is no longer needed on Windows. Changes: - Exclude tray-icon, tao, image dependencies from Windows build - Remove tray module from Windows compilation (cfg gate) - Remove Windows-specific tray code from tray.rs (IPC session count, click handler, start_query_session_count) - Remove --tray argument handling on Windows in core_main.rs - Remove auto-start tray logic on Windows in core_main.rs - Remove tray process spawn in connection.rs - Remove get_tray_shortcut() and tray_shortcuts from windows.rs - Remove tray process tracking in update_me() - Remove tray startup in run_after_run_cmds() and install_service() - Remove LAUNCH_TRAY_APP property and LaunchAppTray action from MSI - Remove StartupFolder.ShortcutTray component from MSI - Remove TryDeleteStartupShortcut custom action from MSI - Remove SC_Client_Tray strings from MSI localization - Remove STARTUPSHORTCUTS property from MSI - Clean up uninstall scripts to remove stale Tray.lnk files Linux and macOS tray functionality remains unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove all tray icon related code, dependencies, and MSI installer configuration for the Windows client. The tray icon is no longer needed on Windows.
Changes
Rust code
tray-icon,tao,imagedependencies from Windows build targettraymodule withcfg(not(target_os = "windows"))start_query_session_countfunction, Windows icon path)--trayargument handling on Windows; remove auto-start tray logic on Windowsget_tray_shortcut(),tray_shortcutsvariable, tray process tracking inupdate_me(), tray startup inrun_after_run_cmds()andinstall_service()MSI installer
LaunchAppTraycustom action,TryDeleteStartupShortcutaction,App.StartupFolder.ShortcutTraycomponentLAUNCH_TRAY_APPpropertyTryDeleteStartupShortcutaction declarationTryDeleteStartupShortcutfunction implementationTryDeleteStartupShortcutexportSTARTUPSHORTCUTSpropertySC_Client_TrayandSC_Client_Tray_DescstringsCleanup
Tray.lnkfiles for backward compatibilityTest plan