feat: hm-common crate + compact duration formatting#169
Merged
Conversation
Introduce the hm-common crate, seeded with a formatting module: a
sealed CompactDuration extension trait on std::time::Duration returning
a StopwatchDurationDisplay (allocation-free Display wrapper). Rendering
follows humantime semantics — lossless, most-significant unit first,
zero units omitted — in compact notation (1s500ms, 1h1m1s, 2h, 1d2h).
Covered by rstest cases plus proptest round-trip/well-formedness.
Wire it into hm-render's progress output, replacing the hand-rolled
format_duration (which capped at minutes, so >=1h rendered as e.g.
"61m1s"). Machine-facing "duration={ms}ms" log lines stay integer ms.
Also adopt the human_units crate for byte-size rendering, collapsing
four hand-rolled formatters (human_mb, human_bytes, and an inline mb
closure) into `.format_size()`. Output shifts to correct IEC labels
(e.g. "6 MiB" instead of the mislabeled 1024-base "6.0 MB").
markovejnovic
marked this pull request as ready for review
July 23, 2026 07:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleaner formatting