Repository navigation
Drop the [Any, Any] type arguments from assertEquals - #76
Merged
Merged
Conversation
munit's Compare instances take an `A <:< B` given, and resolving one for a union type trips -Winfer-union. A UnionSafeCompare test trait gives the same instances through type bounds, which compile without the warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests no longer need
assertEquals[Any, Any]to compare union types (for exampleX | Nullunder-Yexplicit-nulls).munit derives
Compare[A, B]fromcompareSubtypeWithSupertype[A, B](using A <:< B). Resolving a given with a nestedusingfor a union type makes-Winfer-unionwarn, even with explicit type arguments, although nothing is inferred there. That looks like a compiler false positive.The new
UnionSafeComparetest trait provides the same two instances through type bounds (A <: B/B <: A), which compile without the warning. The subtype instance lives in a subtrait so that it wins when both apply. Comparing unrelated types still fails to compile with munit's "Can't compare".🤖 Generated with Claude Code
Summary by CodeRabbit