Skip to content

🔄 synced file(s) with halotukozak-com/.github - #192

Merged
halotukozak merged 1 commit into
mainfrom
repo-sync/github/default
Oct 13, 2026
Merged

halotukozak merged 1 commit into
mainfrom
repo-sync/github/default

Conversation

@halotukozak

@halotukozak halotukozak commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

synced local file(s) with halotukozak-com/.github.

Changed files
  • synced local .github/workflows/mima.yml with remote shared/mima.yml

This PR was created automatically by the repo-file-sync-action workflow run #38365307546

Summary by CodeRabbit

  • Documentation
    • Updated the description of the needs-minor label to clarify that it applies to new APIs or TASTy-only breaks.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: abf191a4-b266-4cf0-8feb-5fa96bbcc6be
📥 Commits

Reviewing files that changed from the base of the PR and between 3475cf1 and e456520.

📒 Files selected for processing (1)
  • .github/workflows/mima.yml
 ______________________________________________________________________
< Your indentation suggests confidence. Your logic suggests otherwise. >
 ----------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the needs-minor New API or a TASTy-only break — needs a minor version bump label Oct 13, 2026
@github-actions

Copy link
Copy Markdown

⚠️ MiMa: TASTy incompatibility vs main@3475cf1

This PR breaks TASTy (but not binary) compatibility — it needs at least a minor version bump.

Check vs main@3475cf1 Result
Binary (MiMa) ✅ compatible
New API (MiMa, forward) none
TASTy (TASTy-MiMa) ❌ incompatible
Implied version bump minor

A TASTy incompatibility means other libraries' inline code that uses this API may fail to re-typecheck when it gets inlined against the new version; that is neither binary nor source compatibility.

Details
MiMa (binary):
[mima] backward (code built against the release vs the new JAR): OK
[mima] forward  (new API vs the release — expected to list additions): OK

TASTy-MiMa (TASTy):
[tasty-mima] backward (TASTy built against the release vs the new JAR): 2 problem(s)
  - The class halotukozak.made.DoneOperation.EmptyApply has an incompatible self type in current version: before: Some(TypeRefinement(TypeRef(PackageRef(halotukozak.made), symbol[class made.DoneOperation]), Args, TypeAlias(TypeRef(TermRef(PackageRef(scala), Tuple$package), EmptyTuple)))); after: Some(TypeRefinement(TypeRef(PackageRef(halotukozak.made), symbol[class made.DoneOperation]), Args, TypeAlias(TypeRef(TermRef(PackageRef(scala), Tuple$package), EmptyTuple))))
  - The class halotukozak.made.DoneOperation.SingleApply has an incompatible self type in current version: before: Some(TypeRefinement(TypeRef(PackageRef(halotukozak.made), symbol[class made.DoneOperation]), Args, TypeAlias(AppliedType(TypeRef(PackageRef(scala), *:), List(TypeRef(ThisType(TypeRef(ThisType(TypeRef(PackageRef(halotukozak.made), symbol[object class made.DoneOperation$])), symbol[class DoneOperation$.SingleApply])), symbol[SingleApply.Arg]), TypeRef(TermRef(PackageRef(scala), Tuple$package), EmptyTuple)))))); after: Some(TypeRefinement(TypeRef(PackageRef(halotukozak.made), symbol[class made.DoneOperation]), Args, TypeAlias(AppliedType(TypeRef(PackageRef(scala), *:), List(TypeRef(ThisType(TypeRef(ThisType(TypeRef(PackageRef(halotukozak.made), symbol[object class made.DoneOperation$])), symbol[class DoneOperation$.SingleApply])), symbol[SingleApply.Arg]), TypeRef(TermRef(PackageRef(scala), Tuple$package), EmptyTuple))))))

@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@halotukozak
halotukozak merged commit 561d9ce into main Oct 13, 2026
9 of 10 checks passed
@halotukozak
halotukozak deleted the repo-sync/github/default branch October 13, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-minor New API or a TASTy-only break — needs a minor version bump sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant