Skip to content

🔄 synced file(s) with halotukozak-com/.github - #189

Merged
halotukozak merged 3 commits into
mainfrom
repo-sync/github/default
Oct 7, 2026
Merged

halotukozak merged 3 commits into
mainfrom
repo-sync/github/default

Conversation

@halotukozak

@halotukozak halotukozak commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

synced local file(s) with halotukozak-com/.github.

Changed files
  • synced local .mima/bin-compat-check.scala with remote .mima/bin-compat-check.scala
  • synced local .mima/tasty-compat-check.scala with remote .mima/tasty-compat-check.scala
  • synced local .github/workflows/mima.yml with remote shared/mima.yml

This PR was created automatically by the repo-file-sync-action workflow run #37605678015

Summary by CodeRabbit

  • New Features
    • Pull requests now distinguish binary incompatibilities, which require a major version bump, from TASTy-only incompatibilities, which require a minor bump.
    • Compatibility reports include results and check logs, and are added to the job summary. Pull request labels and reports update to reflect incompatibilities or later fixes.
  • Bug Fixes
    • Compatibility checks now fail clearly when required JAR files are missing, rather than treating them as empty.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 784bb781-db26-41e5-876f-4481f0361179
📥 Commits

Reviewing files that changed from the base of the PR and between c0d7e09 and 2ca32ab.

📒 Files selected for processing (3)
  • .github/workflows/mima.yml
  • .mima/bin-compat-check.scala
  • .mima/tasty-compat-check.scala
 ______________________________________________________
< Plot twist: Your tests were the real bugs all along. >
 ------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@halotukozak
halotukozak enabled auto-merge October 7, 2026 10:11
@github-actions github-actions Bot added the needs-minor TASTy-incompatible (other libraries' inline code may fail to re-typecheck) — needs a minor bump label Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

⚠️ MiMa: TASTy incompatibility vs main@c0d7e09

This PR breaks TASTy (but not binary) compatibility — it needs at least a minor version bump.

Check vs main@c0d7e09 Result
Binary (MiMa) ✅ compatible
TASTy (TASTy-MiMa) ❌ incompatible
Implied version bump minor

A TASTy incompatibility means other libraries' inline code that uses this API may fail to re-typecheck when it gets inlined against the new version; that is neither binary nor source compatibility.

Details
MiMa (binary):
[mima] backward (code built against the release vs the new JAR): OK
[mima] forward  (new API vs the release — expected to list additions): OK

TASTy-MiMa (TASTy):
[tasty-mima] backward (TASTy built against the release vs the new JAR): 2 problem(s)
  - The class halotukozak.made.DoneOperation.EmptyApply has an incompatible self type in current version: before: Some(TypeRefinement(TypeRef(PackageRef(halotukozak.made), symbol[class made.DoneOperation]), Args, TypeAlias(TypeRef(TermRef(PackageRef(scala), Tuple$package), EmptyTuple)))); after: Some(TypeRefinement(TypeRef(PackageRef(halotukozak.made), symbol[class made.DoneOperation]), Args, TypeAlias(TypeRef(TermRef(PackageRef(scala), Tuple$package), EmptyTuple))))
  - The class halotukozak.made.DoneOperation.SingleApply has an incompatible self type in current version: before: Some(TypeRefinement(TypeRef(PackageRef(halotukozak.made), symbol[class made.DoneOperation]), Args, TypeAlias(AppliedType(TypeRef(PackageRef(scala), *:), List(TypeRef(ThisType(TypeRef(ThisType(TypeRef(PackageRef(halotukozak.made), symbol[object class made.DoneOperation$])), symbol[class DoneOperation$.SingleApply])), symbol[SingleApply.Arg]), TypeRef(TermRef(PackageRef(scala), Tuple$package), EmptyTuple)))))); after: Some(TypeRefinement(TypeRef(PackageRef(halotukozak.made), symbol[class made.DoneOperation]), Args, TypeAlias(AppliedType(TypeRef(PackageRef(scala), *:), List(TypeRef(ThisType(TypeRef(ThisType(TypeRef(PackageRef(halotukozak.made), symbol[object class made.DoneOperation$])), symbol[class DoneOperation$.SingleApply])), symbol[SingleApply.Arg]), TypeRef(TermRef(PackageRef(scala), Tuple$package), EmptyTuple))))))

@halotukozak
halotukozak merged commit fa8f9b7 into main Oct 7, 2026
8 of 9 checks passed
@halotukozak
halotukozak deleted the repo-sync/github/default branch October 7, 2026 10:12
@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-minor TASTy-incompatible (other libraries' inline code may fail to re-typecheck) — needs a minor bump sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant