Repository navigation
docs: everything the mapping file may hold - #46
Merged
Merged
Conversation
…h no volumes needs none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The README showed the mapping file by its
volumesand itschapter_versionsalone. A test (TestLoadIgnoresKeysItDoesNotKnow) says that Manga2Ink keepsmanga.authorandmanga.languagein the file, "see the README", and the README said nothing of them, nor ofmanga,sourceor the keys another program may keep.A table under "When chapter names don't carry a volume number" now lists every key:
schema_version(required,1),volumes(may be empty or left out, and is not used with--no-volumes),chapter_versions(used with or without volumes),manga(title, and the author and language a program keeps; not read),source(not read), and that any other key is ignored. It also says that a series with no volumes needs no file at all:--no-volumes(ADR 0030).Verification
Documentation only;
go test ./...passes, including the test that checks the protocol document against the issue codes.