Repository navigation
feat: -no-volumes binds every chapter of a series into one book with no volumes - #45
Merged
Merged
Conversation
…no volumes (ADR 0030)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
-no-volumesbinds every chapter of a manga into one<manga>.cbzwith no volumes, so the table of contents of the book is the chapters alone (Ch.1,Ch.2, ...) and not a volume with its chapters under it. The volumes that the names, the volume folders or the mapping file give are not used, a chapter that names no volume is in the book too, and the order is the order of the chapters.Manga2Ink got this result until now by writing a mapping that put all the chapters in one invented volume and hiding that volume afterwards. This puts it in the command line (ADR 0006), for whoever uses the tool alone as well. It is additive in protocol version 1 and listed as the capability
no-volumes.without_volumes: trueand one volume (number 1, because a volume has one); a unit'seffective_volumeis that volume and itsmetadata_assignment.statusisnot_applicable; what the name says stays inparser.volume.chapter_versionsof the mapping file still choose among the files of a chapter, now across the series.-no-volumeswith-combineis refused (exit 2,no_volumes_with_combine); it composes with-batch.docs/machine-protocol-v1.md.Verification
go vetandgo test ./...pass, with new tests for the book, the ignored mapping volumes, a volume folder, the gap and the conflict (text and report), the plan, a library and the refusal.Ubunchu!, read only, output elsewhere): oneUbunchu!.cbzof 225 pages and 16 chapters,Ch.1toCh.16, no issues.