Skip to content

fix(ci): collect only colcon junit locations as test reports - #119

Merged
tenzinplatter merged 1 commit into
mainfrom
tenzinplatter/sc-26573/predictive-autopilot-cannot
Oct 22, 2026
Merged

tenzinplatter merged 1 commit into
mainfrom
tenzinplatter/sc-26573/predictive-autopilot-cannot

Conversation

@tenzinplatter

Copy link
Copy Markdown
Collaborator

Story: [sc-26573] https://app.shortcut.com/greenroom-robotics/story/26573

Summary

mise ci test collected every *.xml under build/ and skipped only the known non-reports. acados v0.5.2, vendored into build/ by ament_vendor, ships ros2_templates/.../package.in.xml. The collector copied it into test-reports, and dorny/test-reporter crashed on it (run). The collector now only walks the locations where colcon writes JUnit:

 find_xml(build/)
-  every *.xml, recursively
-    except Testing/ dirs (CTest Site doc)
-    except package.xml
+  build/*.xml                      # pytest --junitxml=build/... (missim)
+  build/<pkg>/pytest.xml           # colcon ament_python
+  build/<pkg>/test_results/**/*.xml  # colcon ament_cmake gtest + lint

Where each location comes from:

  • ament_python: colcon_core/task/python/test/pytest.py writes <build_base>/pytest.xml.
  • ament_cmake: results land under build/<pkg>/test_results/<pkg>/.
  • missim's pixi tasks use --junitxml=build/test_results.xml.

The org-wide --junitxml search found no other path under build/.

Evidence

  • Before: acados_vendor_ros2's Test (pixi) failed with Processing test results from .../ros2_templates/ocp_interface_templates/package.in.xml failed, even though colcon test-result reported 0 failures.
  • After:
    • test_tests.rs checks that foo-prefix/src/foo/templates/package.in.xml, Testing/Test.xml and package.xml are not collected.
    • It checks that build/<pkg>/pytest.xml, build/test_results.xml and test_results/** are collected.
    • cargo test passes and cargo fmt --check is clean. Clippy shows two assert!(x.is_empty()) lints that already exist on main, in test files this PR doesn't touch.

Merge Danger

Door: two-way

Blast Radius: CI reports

Every repo using mise/.github/actions/test gets this on its next action release. A JUnit file written anywhere else under build/ would stop being published as a check. The org search found none.

@tenzinplatter
tenzinplatter marked this pull request as ready for review October 22, 2026 03:58
@tenzinplatter
tenzinplatter merged commit 93b7dc9 into main Oct 22, 2026
1 check passed
@tenzinplatter
tenzinplatter deleted the tenzinplatter/sc-26573/predictive-autopilot-cannot branch October 22, 2026 03:58
greenroom-gremlin Bot added a commit that referenced this pull request Oct 22, 2026
## [8.30.4](https://github.com/greenroom-robotics/mise/compare/mise@8.30.3...mise@8.30.4) (2026-10-22)

### Bug Fixes

* **ci:** collect only colcon junit locations as test reports ([#119](#119)) ([93b7dc9](93b7dc9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant