Repository navigation
feat: add ng namespace so both interfaces can co-exist for now - #35
Merged
Merged
Conversation
… an ng namespace Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ExecuteAndAfterProcessExit is a function returning a list, not a class, so the planned isinstance assertion could never pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…red 1.27.0 middleware interface Adds ConfigureFastDDSEasyMode back to launch_ext.actions, restores the FastDDSClientEnvironment alias and the fastdds_superclient_environment exports in launch_ext.substitutions, and adds the coexistence smoke test for the restored pre-2.0 middleware interface. The file restoration this builds on (configure_fastdds.py, configure_fastdds_easy.py, configure_zenoh.py, configure_middleware.py, discovery_config.py, fastdds_superclient_environment.py, fastdds_profile.xml.j2, and removal of the 2.x middleware_config.py/fastdds_profile.py duplicates) landed in 0aa44e6. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…spec README documented ConfigureZenoh(run_router=...) under the top-level import, but launch_ext.actions.ConfigureZenoh (restored 1.27.0) takes with_router; run_router only exists on launch_ext.ng.actions.ConfigureZenoh. Give it the same two-generation treatment as the ConfigureFastDDS section. Add test/launch_ext/test_fastdds_profile_legacy.py to pin the restored FastDDSProfileSubstitution's rendering output, mirroring the ng template's existing test coverage, so cross-wiring the two FastDDS templates (both use jinja2's default Undefined) fails a test instead of silently rendering empty values. Reword the spec's description of FastDDSProfileSubstitution's template lookup to match the actual jinja2 Environment/FileSystemLoader mechanism instead of implying a PathJoinSubstitution-style lookup. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
russkel
marked this pull request as ready for review
September 16, 2026 08:33
MrBlenny
pushed a commit
that referenced
this pull request
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.