Skip to content

feat: pixi conversion - #29

Merged
tenzinplatter merged 54 commits into
mainfrom
tenzinplatter/pixi-conversion
Jul 28, 2026
Merged

tenzinplatter merged 54 commits into
mainfrom
tenzinplatter/pixi-conversion

Conversation

@tenzinplatter

Copy link
Copy Markdown
Contributor

Polishes the pixi side-by-side path on launch_ext to match the platform_toolbox reference (PR #61). Single root-level ament_python package.

Pixi path

  • Workflows: pixi runners -> `runs-on=${{ github.run_id }}/runner=2cpu-linux-x64`; `publish-pixi.yml` gains a `mise ci build --package-dir=.` gate before `recipes-pr`; teardown bumped to @V3. `release-pixi.yml` renamed to `release-pixi.yml.disabled`.
  • `pixi.toml`: channel port 8000 -> 12222 (`/general`), backend pinned `pixi-build-ros-gr >=0.4,<0.5`, build-number already inside `[package.build.config]`. Added `[feature.tests]` env (colcon build+test) and `[environments] tests`. Dropped unused `hatchling` host-dep.
  • Removed `pyproject.toml`: it was a stray hatchling manifest that broke the colcon source build (setuptools tried to apply its `[project]` table and crashed). The pixi-build-ros-gr backend builds ament_python from `setup.py` (same as toolbox), so it is unnecessary.
  • `.taplo.toml`: added `[formatting]` block; pixi.toml reformatted by taplo. Added taplo-format pre-commit hook (union with existing hooks).
  • `pixi.lock` regenerated against the 12222 proxy.

Deb path: unchanged vs main

No deb-path file differs from `origin/main` (package.xml, setup.py, sources, tests, release.yml, ci.yml.disabled, devcontainer all byte-identical).

Verification

  • Backend build (publish gate): `pixi build` -> "Successfully published 1 package(s)" (launch-ext-1.22.3).
  • colcon tests env: 22/23 pass. The 1 failure (`test_include_package_launch_file`) asserts a hardcoded `/opt/ros/kilted/...` path; it is environment-specific to the deb install layout, not a pixi defect.

Risks

  • Large `pixi.lock` churn from the port bump (expected).
  • The one path-assertion test failure is pre-existing/environment-specific.

# Conflicts:
#	.gitignore
@tenzinplatter
tenzinplatter marked this pull request as ready for review July 9, 2026 23:30
Comment thread .pre-commit-config.yaml
- id: flake8
args: ["--ignore=E203, E266, E501, W503, F403, F401 --max-line-length = 99"]

- repo: https://github.com/ComPWA/taplo-pre-commit

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fork or pin to a commit, this doesn't look like it's maintained?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issues seem to be getting responses from what i assume is a maintainer, I think forking this now is probably a bit overkill, maybe just fork when we hit an issue with it?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing, let's pin to a commit hash then

Comment thread launch_ext/actions/configure_zenoh.py Outdated
@natrad100
natrad100 requested a review from MrBlenny July 28, 2026 01:14

@natrad100 natrad100 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before merging, just pin the commit hash

@tenzinplatter
tenzinplatter merged commit fb30e47 into main Jul 28, 2026
2 checks passed
@tenzinplatter
tenzinplatter deleted the tenzinplatter/pixi-conversion branch July 28, 2026 01:17
MrBlenny pushed a commit that referenced this pull request Sep 16, 2026
## [2.1.0](2.0.1...2.1.0) (2026-09-16)

### Features

* add ng namespace so both interfaces can co-exist for now ([#35](#35)) ([565c666](565c666))
* pixi conversion ([#29](#29)) ([fb30e47](fb30e47)), closes [#33](#33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants