Repository navigation
const_array_elements limit test: split into MAX, MAX/8, MAX/64 cases - #4497
Merged
Merged
Conversation
The MAX const array size is 2047. The driver compiler can take a long time compiling the MAX case. For example a laptop with an Intel Gen12 LP GPU with the Mesa driver can take 28s to compile the shader. This exceeds Chrome's GPU watchdog timeout (10s) and the test will fail. Instead of completely disabling the test, split it into cases for MAX, MAX/8, and MAX/64 elements. This lets us skip the very largest cases, but still attempt smaller bug significant array sizes. That lets us get some signal that the large-ish const arrays are viable. The additional runtime for the new cases are insignificant compared to the full case. Fixed: gpuweb#4496
petermcneeleychromium
approved these changes
Nov 7, 2025
petermcneeleychromium
left a comment
Contributor
There was a problem hiding this comment.
This looks great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MAX const array size is 2047.
The driver compiler can take a long time compiling the MAX case. For example a laptop with an Intel Gen12 LP GPU with the Mesa driver can take 28s to compile the shader. This exceeds Chrome's GPU watchdog timeout (10s) and the test will fail.
Instead of completely disabling the test, split it into cases for MAX, MAX/8, and MAX/64 elements. This lets us skip the very largest cases, but still attempt smaller bug significant array sizes. That lets us get some signal that the large-ish const arrays are viable.
The additional runtime for the new cases are insignificant compared to the full case.
Fixed: #4496
Issue: #
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.