Skip to content

Make gen_version fail gracefully if git is not available - #4455

Merged
kainino0x merged 3 commits into
mainfrom
genversiongit
Sep 10, 2025
Merged

kainino0x merged 3 commits into
mainfrom
genversiongit

Conversation

@kainino0x

@kainino0x kainino0x commented Sep 9, 2025 •

Copy link
Copy Markdown
Collaborator

Chrome infra wants to npx grunt node on a VM that doesn't have Git. gen_version is not actually used in out-node builds but npx grunt node triggers it anyway (it just doesn't copy the result to the output). Changing this in the gruntfile is hard (there are weird dependencies because the gen directory needs to be cleaned every time to delete old files) but this is fine.

Issue: none, see #4452


Requirements for PR author:

  • [n/a] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [n/a] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [n/a] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [n/a] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • [n/a] Tests are properly located in the test tree.
  • [n/a] Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • [n/a] Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@kainino0x
kainino0x enabled auto-merge (squash) September 10, 2025 17:17
@kainino0x
kainino0x merged commit 3ec15ab into main Sep 10, 2025
1 check passed
@kainino0x
kainino0x deleted the genversiongit branch September 10, 2025 17:21
greggman pushed a commit to greggman/cts that referenced this pull request Oct 14, 2025
Chrome infra wants to `npx grunt node` on a VM that doesn't have Git. gen_version is not actually used in `out-node` builds but `npx grunt node` triggers it anyway (it just doesn't copy the result to the output). Changing this in the gruntfile is hard (there are weird dependencies because the gen directory needs to be cleaned every time to delete old files) but this is fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants