Repository navigation
Make gen_version fail gracefully if git is not available - #4455
Merged
Merged
Conversation
8 tasks
greggman
approved these changes
Sep 9, 2025
kainino0x
enabled auto-merge (squash)
September 10, 2025 17:17
greggman
pushed a commit
to greggman/cts
that referenced
this pull request
Oct 14, 2025
Chrome infra wants to `npx grunt node` on a VM that doesn't have Git. gen_version is not actually used in `out-node` builds but `npx grunt node` triggers it anyway (it just doesn't copy the result to the output). Changing this in the gruntfile is hard (there are weird dependencies because the gen directory needs to be cleaned every time to delete old files) but this is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome infra wants to
npx grunt nodeon a VM that doesn't have Git. gen_version is not actually used inout-nodebuilds butnpx grunt nodetriggers it anyway (it just doesn't copy the result to the output). Changing this in the gruntfile is hard (there are weird dependencies because the gen directory needs to be cleaned every time to delete old files) but this is fine.Issue: none, see #4452
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.